Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(orchestration): return vows #9530

Closed
wants to merge 1 commit into from

Conversation

0xpatrickdev
Copy link
Member

@0xpatrickdev 0xpatrickdev commented Jun 18, 2024

refs: #9449

Description

Builds on #9454, returning Vows instead of Promises

To Do

  • ensure yarn lint:ts passes
    • These are failing due to differences in the host and consumer apis. The latter expects Promises, while the former now returns Vows.
  • ensure bootstrap tests pass, or tests these paths elsewhere
    • The failing tests are all non-wallet tests. it seems we should confirm all tests that would be removed are covered in unit tests, and remove them. From what I gather /boot is not the best place for these sort of tests.

Copy link

cloudflare-workers-and-pages bot commented Jun 18, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 24b0f0f
Status:🚫  Build failed.

View logs

@turadg turadg force-pushed the pc/9449-icq-connection-vows branch 3 times, most recently from 5fccb85 to c0fd411 Compare June 19, 2024 19:40
Base automatically changed from pc/9449-icq-connection-vows to master June 19, 2024 20:33
- builds off of previous commits, which preserved functionality of returning promises, to return vows
@0xpatrickdev 0xpatrickdev force-pushed the pc/9499-orchestration-vows branch from f318f58 to 24b0f0f Compare June 19, 2024 21:21
@0xpatrickdev
Copy link
Member Author

Superseded by #9591

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant