9281 durable orchestrator #9532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
62bdb8a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8390c7ee.agoric-sdk.pages.dev |
| Branch Preview URL: | https://9281-local-exo.agoric-sdk.pages.dev |
0xpatrickdev
approved these changes
Jun 19, 2024
| chainId: localChainInfo.chainId, | ||
| addressEncoding: 'bech32', | ||
| }), | ||
| // FIXME storage path |
There was a problem hiding this comment.
What ticket capture this? Maybe vstorage logging ?
Suggested change
| // FIXME storage path | |
| // FIXME storage path https://github.com/Agoric/agoric-sdk/issues/9066 |
There was a problem hiding this comment.
Thanks for looking these up. I expect we'll get to them soon so I'll let this merge as is to save the CI time. Maybe include the links on a next PR.
| @@ -169,7 +169,7 @@ export const prepareChainAccountKit = zone => | |||
| }, | |||
| async onClose(_connection, reason) { | |||
| trace(`ICA Channel closed. Reason: ${reason}`); | |||
| // XXX handle connection closing | |||
| // FIXME handle connection closing | |||
There was a problem hiding this comment.
Suggested change
| // FIXME handle connection closing | |
| // FIXME handle connection closing https://github.com/Agoric/agoric-sdk/issues/9192 |
| @@ -67,18 +58,18 @@ const PUBLIC_TOPICS = { | |||
| * @param {Remote<TimerService>} timerService | |||
| * @param {ChainHub} chainHub | |||
| */ | |||
| export const prepareLocalChainAccountKit = ( | |||
| export const prepareLocalOrchestrationAccountKit = ( | |||
| return V(this.state.account).deposit(payment, optAmountShape); | ||
| /** @type {OrchestrationAccount<any>['deposit']} */ | ||
| async deposit(payment) { | ||
| await V(this.state.account).deposit(payment); |
There was a problem hiding this comment.
In a future PR we might consider updating OrchestrationAccountI['deposit'] to return Promise<Amount<'nat'>>. I don't see a reason to swallow that response.
Tangentially - with the revised implementation plan for #9193 only LocalOrchestrationAccount will have .deposit().
mergify bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
closes: #XXXX refs: #9532 which seems to be where the `M.bigint()` came from ## Description The `DenomAmountShape` was using only `M.bigint()` to validate a DenomAmount, which misses an opportunity to easily ensure that these amount values never go negative. This PR changes this to `M.nat()`, making it consistent with the immediately following `AnyNatAmountShape` as well. ### Security Considerations Accidentally admitting negative value amounts might enable attacks allowing overdrawn spending or creation of new units. There may or may not be such a security vulnerability in this code, depending on whether the non-negative condition is ensured by other means, which I cannot determine. But fixing this is *at least* a belt-and-suspenders enforcement, through a declarative expression of the constraint. ### Scaling Considerations none ### Documentation Considerations should just remove the need to explain something else for the programmer to worry about. ### Testing Considerations If we can find an actual vulnerability that this PR fixes, then we could test the difference. But I have not. ### Upgrade Considerations If there are any such negative values in existing use, this PR is likely to break them. But their presence likely indicates corruption that we'd be better off causing a failure, rather than proceeding silently to corrupt other state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #9281
Description
AsyncFlow requires that everything passing the membrane is durable. This makes the facade objects durable to conform.
Following #9529
Security Considerations
none
Scaling Considerations
Exo for each chain and each account
Documentation Considerations
none
Testing Considerations
Existing coverage
Upgrade Considerations
not yet deployed