test(orchestration): skip non-invitation-based boot tests #9573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
5ba21bc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://20b0729b.agoric-sdk.pages.dev |
| Branch Preview URL: | https://pc-9449-orch-returns-vows.agoric-sdk.pages.dev |
it doesn't make working with vows convenient, but I think you can sort of write it out long-hand. A vow is a tagged thing with a certain payload and such |
dckc
approved these changes
Jun 24, 2024
| const publicFacet = await EV(zoe).getPublicFacet(instance); | ||
| t.truthy(publicFacet, 'stakeAtom publicFacet is available'); | ||
|
|
||
| const account = await EV(publicFacet).makeAccount(); |
There was a problem hiding this comment.
makeAccount is tested below stakeAtom - smart wallet and delegate
| }; | ||
| await t.notThrowsAsync(EV(account).delegate(validatorAddress, atomAmount)); | ||
|
|
||
| await t.throwsAsync(EV(account).getBalance('uatom'), { |
There was a problem hiding this comment.
not a likely flow; probably front-end
Pushed up our spike on EV support of Vows to TLDR;
|
0xpatrickdev
force-pushed
the
pc/9449-orch-returns-vows
branch
from
7e83a07 to
5ba21bc
Compare
0xpatrickdev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #9449
Description
Disables
@agoric/orchestrationtests inpackages/bootthat interact directly with Vows.EVdoes not currently support vows, and these tests block efforts related to #9449.For tests that are skipped and not deleted, I propose testing these paths after the completion of #9572.
Testing Considerations
Skips tests instead deleting them. Taking on some tech debt until #9572