fix(orchestration): errors should have error messages #9593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
7d51692
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://85df1d4d.agoric-sdk.pages.dev |
| Branch Preview URL: | https://markm-better-error-message.agoric-sdk.pages.dev |
erights
force-pushed
the
markm-better-error-message
branch
from
5df86c8
to
6fcccfa
Compare
0xpatrickdev
approved these changes
Jun 26, 2024
|
Thanks, this is much clearer. Also confirming your choice on the redaction - if we are able to see the response in debug logs that's sufficient. |
erights
added
automerge:squash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #XXXX
refs: #9519
Description
While trying to debug #9519 , I'm seeing errors like
which only has the data without any message text saying what's wrong with the data. While fixing, also switched to a
Failto give us control over redaction. I made the conservative assumption that to not unredact the actual packet data, because I don't know why it should be public on the error even in non-debugging scenarios. If it should be unredacted, I can easily change to${q(response)}. Reviewers, please advise.Note that either way, the unredacted info will still show up in error logs, as above, and will still even show up on the error object in standard debugging configurations.
Security Considerations
Possibly repaired an unintended disclosure of info that should have been redacted, though the main motivation was adding an informative error message.
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
none
Upgrade Considerations
none