orchestrate() returns vow #9701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
59229fa
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://369560c8.agoric-sdk.pages.dev |
| Branch Preview URL: | https://ta-return-vow.agoric-sdk.pages.dev |
mhofman
reviewed
Jul 12, 2024
| @@ -452,6 +453,7 @@ export const prepareAsyncFlowTools = (outerZone, outerOptions = {}) => { | |||
| defineProperties(wrapperFunc, { | |||
| length: { value: guestFunc.length }, | |||
| }); | |||
| // @ts-expect-error cast | |||
There was a problem hiding this comment.
curious, why not cast instead? actually couldn't we set the type at the definition above?
const wrapperFunc = {
/** @type {HostOf<F>} */
[hostFuncName](...args) {
packages/orchestration/src/facade.js
Outdated
Comment on lines
82
to
83
| // @ts-expect-error cast | ||
| hostFn(wrappedOrc, wrappedCtx, ...args); |
There was a problem hiding this comment.
I'm not really a fan of error suppressions on whole lines that could have multiple errors.
0xpatrickdev
approved these changes
Jul 15, 2024
| @@ -121,7 +122,7 @@ test('send using arbitrary chain info', async t => { | |||
| { Send }, | |||
| { destAddr: 'hot1destAddr', chainName }, | |||
| ); | |||
| await E(userSeat).getOfferResult(); | |||
| await vt.when(E(userSeat).getOfferResult()); | |||
There was a problem hiding this comment.
I forget where we landed on aliasing heapVowE to E in tests. These are tests that we expect developers to write and vt.when(E(x).foo()) might be confusing.
There was a problem hiding this comment.
My gut says papering over this difference will be riskier. Let's see how it plays out
turadg
force-pushed
the
ta/return-vow
branch
2 times, most recently
from
881e4a8 to
2f04c0b
Compare
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
the rights are granted by the invitationMakers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up on #9449
Description
orchestratereturns a Promise instead of a Vow.holderfrom ResolvedContinuingInvitation b/c theinvitationMakersprovide the ocapsorchestratetypedef to infer the return type from its argumentsSecurity Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
CI
Upgrade Considerations
not yet deployed