fix(orchestration): chain-info #9712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `reverseConnInfo` utility to flip connection info perspective - Modify `registerChain` to normalize connection info before storage - Ensure consistent storage based on lexicographically smaller chain ID
- properly specify hostConnectionId (remote chain) and controllerConnectionId (local chain) parameters
Deploying agoric-sdk with
|
| Latest commit: |
746261e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://31735579.agoric-sdk.pages.dev |
| Branch Preview URL: | https://pc-fix-chain-info.agoric-sdk.pages.dev |
0xpatrickdev
force-pushed
the
pc/fix-chain-info
branch
from
cf5838a
to
be3e273
Compare
turadg
approved these changes
Jul 15, 2024
| @@ -53,8 +53,8 @@ function toConnectionEntry(ibcInfo, name, chainInfo) { | |||
| } | |||
| const [channel] = transferChannels; | |||
| const [channelFrom, channelTo] = fromChain1 | |||
| ? [channel.chain_2, channel.chain_1] | |||
| : [channel.chain_1, channel.chain_2]; | |||
| ? [channel.chain_1, channel.chain_2] | |||
There was a problem hiding this comment.
in hindsight a unit test for the direction would have helped. not worthwhile now imo
- updates multichain-e2e.yml job to print validator and relayer logs
0xpatrickdev
force-pushed
the
pc/fix-chain-info
branch
from
be3e273
to
746261e
Compare
0xpatrickdev
commented
Jul 15, 2024
mergify bot
added a commit
that referenced
this pull request
Jul 15, 2024
_incidental_ ## Description Motivated by #9712 (comment) This fixes up ChainHub to return IBCConnectionInfo in the perspective of the directed edge implied by the chain arguments. The data is the same in either direction, just reversed, so we store it just once. This adds the logic to normalize on save and denormalize on read. ### Security Considerations none ### Scaling Considerations Some extra compute when saving or reading a chain. Low call rate. ### Documentation Considerations none ### Testing Considerations New tests ### Upgrade Considerations Not yet deployed
dckc
reviewed
Jul 16, 2024
| @@ -70,31 +70,31 @@ Generated by [AVA](https://avajs.dev). | |||
| ], | |||
| [ | |||
| 'published.agoricNames.chainConnection.agoric-3_cosmoshub-4', | |||
| '{"blockHeight":"0","values":["{\\"body\\":\\"{\\\\\\"client_id\\\\\\":\\\\\\"07-tendermint-6\\\\\\",\\\\\\"counterparty\\\\\\":{\\\\\\"client_id\\\\\\":\\\\\\"07-tendermint-927\\\\\\",\\\\\\"connection_id\\\\\\":\\\\\\"connection-649\\\\\\",\\\\\\"prefix\\\\\\":{\\\\\\"key_prefix\\\\\\":\\\\\\"FIXME\\\\\\"}},\\\\\\"id\\\\\\":\\\\\\"connection-8\\\\\\",\\\\\\"state\\\\\\":3,\\\\\\"transferChannel\\\\\\":{\\\\\\"channelId\\\\\\":\\\\\\"channel-405\\\\\\",\\\\\\"counterPartyChannelId\\\\\\":\\\\\\"channel-5\\\\\\",\\\\\\"counterPartyPortId\\\\\\":\\\\\\"transfer\\\\\\",\\\\\\"ordering\\\\\\":0,\\\\\\"portId\\\\\\":\\\\\\"transfer\\\\\\",\\\\\\"state\\\\\\":3,\\\\\\"version\\\\\\":\\\\\\"ics20-1\\\\\\"}}\\",\\"slots\\":[]}","{\\"body\\":\\"{\\\\\\"client_id\\\\\\":\\\\\\"07-tendermint-927\\\\\\",\\\\\\"counterparty\\\\\\":{\\\\\\"client_id\\\\\\":\\\\\\"07-tendermint-6\\\\\\",\\\\\\"connection_id\\\\\\":\\\\\\"connection-8\\\\\\",\\\\\\"prefix\\\\\\":{\\\\\\"key_prefix\\\\\\":\\\\\\"FIXME\\\\\\"}},\\\\\\"id\\\\\\":\\\\\\"connection-649\\\\\\",\\\\\\"state\\\\\\":3,\\\\\\"transferChannel\\\\\\":{\\\\\\"channelId\\\\\\":\\\\\\"channel-5\\\\\\",\\\\\\"counterPartyChannelId\\\\\\":\\\\\\"channel-405\\\\\\",\\\\\\"counterPartyPortId\\\\\\":\\\\\\"transfer\\\\\\",\\\\\\"ordering\\\\\\":0,\\\\\\"portId\\\\\\":\\\\\\"transfer\\\\\\",\\\\\\"state\\\\\\":3,\\\\\\"version\\\\\\":\\\\\\"ics20-1\\\\\\"}}\\",\\"slots\\":[]}"]}', | |||
| '{"blockHeight":"0","values":["{\\"body\\":\\"{\\\\\\"client_id\\\\\\":\\\\\\"07-tendermint-6\\\\\\",\\\\\\"counterparty\\\\\\":{\\\\\\"client_id\\\\\\":\\\\\\"07-tendermint-927\\\\\\",\\\\\\"connection_id\\\\\\":\\\\\\"connection-649\\\\\\",\\\\\\"prefix\\\\\\":{\\\\\\"key_prefix\\\\\\":\\\\\\"FIXME\\\\\\"}},\\\\\\"id\\\\\\":\\\\\\"connection-8\\\\\\",\\\\\\"state\\\\\\":3,\\\\\\"transferChannel\\\\\\":{\\\\\\"channelId\\\\\\":\\\\\\"channel-5\\\\\\",\\\\\\"counterPartyChannelId\\\\\\":\\\\\\"channel-405\\\\\\",\\\\\\"counterPartyPortId\\\\\\":\\\\\\"transfer\\\\\\",\\\\\\"ordering\\\\\\":0,\\\\\\"portId\\\\\\":\\\\\\"transfer\\\\\\",\\\\\\"state\\\\\\":3,\\\\\\"version\\\\\\":\\\\\\"ics20-1\\\\\\"}}\\",\\"slots\\":[]}","{\\"body\\":\\"{\\\\\\"client_id\\\\\\":\\\\\\"07-tendermint-6\\\\\\",\\\\\\"counterparty\\\\\\":{\\\\\\"client_id\\\\\\":\\\\\\"07-tendermint-927\\\\\\",\\\\\\"connection_id\\\\\\":\\\\\\"connection-649\\\\\\",\\\\\\"prefix\\\\\\":{\\\\\\"key_prefix\\\\\\":\\\\\\"\\\\\\"}},\\\\\\"id\\\\\\":\\\\\\"connection-8\\\\\\",\\\\\\"state\\\\\\":3,\\\\\\"transferChannel\\\\\\":{\\\\\\"channelId\\\\\\":\\\\\\"channel-5\\\\\\",\\\\\\"counterPartyChannelId\\\\\\":\\\\\\"channel-405\\\\\\",\\\\\\"counterPartyPortId\\\\\\":\\\\\\"transfer\\\\\\",\\\\\\"ordering\\\\\\":0,\\\\\\"portId\\\\\\":\\\\\\"transfer\\\\\\",\\\\\\"state\\\\\\":3,\\\\\\"version\\\\\\":\\\\\\"ics20-1\\\\\\"}}\\",\\"slots\\":[]}"]}', | |||
There was a problem hiding this comment.
It would be nice to decode these vstorage items for the snapshot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #9063
Description
Fixes bugs in unreleased code related to publishing
IBCConnectionInfoto vstorage and parameterizing ICA channel creation.Testing Considerations
These were surfaced in E2E testing. Includes an additional test to verify connection info between two well known chains, as current snapshots are a bit hard to decipher.
Upgrade Considerations
Changes unreleased code.