-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc Orchestration cleanup #9720
Conversation
Deploying agoric-sdk with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good stuff.
one suggestion
@@ -35,9 +35,6 @@ export const Proto3Shape = { | |||
value: M.string(), | |||
}; | |||
|
|||
// XXX same as ChainAmountShape and DenomAmount type | |||
export const CoinShape = { value: M.bigint(), denom: M.string() }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
* @template {(orc: Orchestrator, ctx: any, ...args: any[]) => Promise<any>} GF | ||
* @typedef {GF extends ( | ||
* orc: Orchestrator, | ||
* ctx: any, | ||
* ...args: infer GA | ||
* ) => Promise<infer GR> | ||
* ? (...args: HostArgs<GA>) => Vow<GR> | ||
* : never} HostForGuest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is at the edge of my tsc-fu; an example in the form of a type test would help me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worthwhile. probably another PR.
incidental
Description
Miscellaneous cleanups while starting #9719 for #9303.
See each commit title for changes
Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
CI
Upgrade Considerations
not yet deployed