vat-safe cosmic-proto top level #9743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
7dd34e3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://26d7b846.agoric-sdk.pages.dev |
| Branch Preview URL: | https://9578-fix-protos-import.agoric-sdk.pages.dev |
turadg
force-pushed
the
9578-fix-protos-import
branch
from
61a50a1 to
4d7e50a
Compare
turadg
force-pushed
the
9578-fix-protos-import
branch
from
4d7e50a to
7dd34e3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9743 +/- ##
==========================================
+ Coverage 55.77% 56.37% +0.59%
==========================================
Files 680 667 -13
Lines 213499 207526 -5973
Branches 352 339 -13
==========================================
- Hits 119081 116988 -2093
+ Misses 94300 90419 -3881
- Partials 118 119 +1
|
0xpatrickdev
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #9578
Description
The reason for #9578 was an import from
@agoric/cosmic-protoin a vat instead of@agoric/cosmic-proto/vatsafe. That's quite an easy error to make (a footgun) so this makes the top level module export be the "vat safe" one.When consumers want the convenience of a barrel export or rpc clients that can resolve anything (#9200), they can use a different subpath.
Security Considerations
none
Scaling Considerations
can reduce bundle size
Documentation Considerations
reduces need to document
Testing Considerations
existing coverage
Upgrade Considerations
affects only new bundles