-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: getVBankAssetInfo() on orch.getChain('agoric') #9798
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with Cloudflare Pages
|
turadg
reviewed
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
glad to see it
dckc
force-pushed
the
dc-vbank-ag-chain
branch
2 times, most recently
from
July 29, 2024 23:23
ffff61a
to
ad89f4a
Compare
dckc
changed the title
feat: getVBankAssets() on orc.getChain('agoric') (WIP)
feat: getVBankAssets() on orc.getChain('agoric')
Jul 29, 2024
dckc
changed the title
feat: getVBankAssets() on orc.getChain('agoric')
feat: getVBankAssets() on orch.getChain('agoric')
Jul 29, 2024
turadg
requested changes
Jul 30, 2024
dckc
changed the title
feat: getVBankAssets() on orch.getChain('agoric')
feat: getVBankAssetInfo() on orch.getChain('agoric')
Jul 31, 2024
turadg
approved these changes
Jul 31, 2024
dckc
force-pushed
the
dc-vbank-ag-chain
branch
2 times, most recently
from
July 31, 2024 14:53
a3f6b73
to
590dd03
Compare
3 tasks
dckc
force-pushed
the
dc-vbank-ag-chain
branch
2 times, most recently
from
July 31, 2024 22:36
041230d
to
8257e9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #9541, #9322, #9519
Description
add
getVBankAssetInfo()
method on agoric chain object.DRAFT until
getChain()
?makeResumableAgoricNamesHack
to use thisDocumentation Considerations
change is visible via
orchestration-api.d.ts
cc @dtribble
Security Considerations
none?
Scaling Considerations
returns O(n) data from O(1) args
Testing Considerations
perhaps not independently tested
Upgrade Considerations
not yet deployed