chore: parameterize price feed replacement (check liquidation) #9827

dckc · 2024-08-01T22:17:34Z

DRAFT until:

fill in the right per-brand proposals
adjust setup, outcome constants

stacked on

coreEval for replacing price feeds #9999

was:

Repair vaultUpgrade proposal; also register replacement scaledPriceAuthority #9748

Description

/**
 * @file  The goal of this test is  to see that the
 * upgrade scripts re-wire all the contracts so new auctions and
 * price feeds are connected to vaults correctly.
 *
 * 1. enter a bid
 * 2. force prices to drop so a vault liquidates
 * 3. verify that the bidder gets the liquidated assets.
 */

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

dckc · 2024-08-01T22:19:01Z

runs like this so far:

...
  ─

  1. setupVaults; placeBids

  Error: Test finished without running any assertions



  run replace-price-feeds proposals
  Error: Test finished without running any assertions



  2. trigger liquidation by changing price

  test/bootstrapTests/price-feed-replace.test.ts:97

   96:   await advanceTimeTo(NonNullish(liveSchedule.nextDescendingStepTime));
   97:   t.like(readLatest(metricsPath), {                                    
   98:     numActiveVaults: 0,                                                

  Difference (- actual, + expected):

    {
      liquidatingCollateral: {
  -     value: 0n,
  +     value: 45000000n,
      },
      liquidatingDebt: {
  -     value: 0n,
  +     value: 309540000n,
      },
      lockedQuote: null,
  -   numActiveVaults: 1,
  +   numActiveVaults: 0,
  -   numLiquidatingVaults: 0,
  +   numLiquidatingVaults: 1,
    }

  › Object.value [as like] (file:///home/connolly/projects/agoric-sdk/node_modules/@endo/ses-ava/src/ses-ava-test.js:164:35)
  › <anonymous> (test/bootstrapTests/price-feed-replace.test.ts:97:5)



  3. verify liquidation
  test/bootstrapTests/price-feed-replace.test.ts:113

   112:   await advanceTimeBy(3, 'minutes');                                       
   113:   t.like(readLatest(`published.auction.book${managerIndex}`), {            
   114:     collateralAvailable: { value: scale6(setup.auction.start.collateral) },

  Difference (- actual, + expected):

    {
      collateralAvailable: {
  -     value: 0n,
  +     value: 45000000n,
      },
      startCollateral: {
  -     value: 0n,
  +     value: 45000000n,
      },
  -   startProceedsGoal: null,
  +   startProceedsGoal: {
  +     value: 309540000n,
  +   },
    }

  › Object.value [as like] (file:///home/connolly/projects/agoric-sdk/node_modules/@endo/ses-ava/src/ses-ava-test.js:164:35)
  › <anonymous> (test/bootstrapTests/price-feed-replace.test.ts:113:5)

  ─

  4 tests failed
error Command failed with exit code 1.

cloudflare-workers-and-pages · 2024-08-01T23:12:11Z

Deploying agoric-sdk with Cloudflare Pages

Latest commit:	`3d6c4e7`
Status:	✅ Deploy successful!
Preview URL:	https://9d61d2cb.agoric-sdk.pages.dev
Branch Preview URL:	https://9584-up-vault-dc.agoric-sdk.pages.dev

View logs

dckc · 2024-09-03T20:36:47Z

@Chris-Hibbert help me understand why liquidation is not triggering?

p.s. because the updated price is coming from a feed that vaults/auctions have yet to be introduced to.

✘ [fail]: 3. verify liquidation

$ yarn test test/bootstrapTests/price-feed-replace.test.ts
...

  ✘ [fail]: 3. verify liquidation
  ─

  3. verify liquidation

  test/bootstrapTests/price-feed-replace.test.ts:125

   124:   // vaultFactory sent collateral for liquidation
   125:   t.like(readLatest(metricsPath), {              
   126:     numActiveVaults: 0,                          

  Difference (- actual, + expected):

    {
      liquidatingCollateral: {
  -     value: 0n,
  +     value: 15000000n,
      },
      liquidatingDebt: {
  -     value: 0n,
  +     value: 100500000n,
      },
      lockedQuote: null,
  -   numActiveVaults: 1,
  +   numActiveVaults: 0,
  -   numLiquidatingVaults: 0,
  +   numLiquidatingVaults: 1,
    }

  › Object.value [as like] (file:///home/connolly/projects/agoric-sdk/node_modules/@endo/ses-ava/src/ses-ava-test.js:164:35)
  › <anonymous> (test/bootstrapTests/price-feed-replace.test.ts:125:5)

  ─

  1 test failed
error Command failed with exit code 1.

I rebased it on #9999. There's more to do, but I'd like to get this part working.

github-actions · 2024-09-09T19:05:16Z

Base branch is changed to master. Please re-run the integration tests by adding 'force:integration' label.

When a new price aggregator is launched, oracle operators need to accept new invitations.

dckc · 2024-09-10T18:06:27Z

@Chris-Hibbert over to you as of 3d6c4e7

Chris-Hibbert

I have two questions.

I saw that you addressed the missing consume power.

Chris-Hibbert · 2024-09-10T20:35:30Z

packages/boot/test/bootstrapTests/price-feed-replace.test.ts

+  await priceFeedDrivers[collateralBrandKey].refreshInvitations();
+});
+
+test.serial('1. place bid', async t => {


@turadg has pointed out that test.serial() doesn't mean "must run in this order". It apparently means "must run one at a time in some order".

Should we do something else for tests that must run in a particular order?

when tests must run in a particular order, they're better thought of as one test. if you want more structure around the steps, a little helper can be made to log the progress.

Chris-Hibbert · 2024-09-10T20:50:02Z

packages/inter-protocol/src/proposals/deploy-price-feeds.js

+  oracleBrandProduce[name].reset();
+  oracleBrandProduce[name].resolve(brand);


Why is it okay for this to overwrite existing brands? Do we expect to use that ability?

Probably not.

provideInertBrand(name) gives the same result for the same name, so it shouldn't make any difference.

But the .reset() is probably a distraction.

I'll drop the reset(). Thanks.

Chris-Hibbert · 2024-09-10T21:16:29Z

packages/inter-protocol/src/proposals/deploy-price-feeds.js

+    [deployPriceFeeds.name]: {
+      consume: {
+        agoricNamesAdmin: t,
+        board: t,
+        chainStorage: t,
+        chainTimerService: t,
+        econCharterKit: t,
+        highPrioritySendersManager: t,
+        namesByAddressAdmin: t,
+        priceAuthority: t,
+        priceAuthorityAdmin: t,
+        startGovernedUpgradable: t,
+        zoe: t,
+      },
+      instance: {
+        produce: t,
+      },
+    },


installPriceAggregator needs

installation: { produce: { priceAggregator }, },

I see that a later commit handled this.

Chris-Hibbert · 2024-09-24T23:57:37Z

This has been incorporated into #10074.

closes: #9584 closes: #9928 refs: #9827 refs: #9748 refs: #9382 closes: #10031 ## Description We added upgrading the scaledPriceAuthority to the steps in upgrading vaults, auctions, and priceFeeds, and didn't notice that it broke things. The problem turned out to be that the "priceAuthority" object registered with the priceFeedRegistry was an ephemeral object that was not upgraded. This fixes that by re-registering the new priceAuthority. Then, to simplify the process of cleaning up the uncollected cycles reported in #9483, we switched to replacing the scaledPriceAuthorities rather than upgrading them. We also realized that we would need different coreEvals in different environments, since the Oracle addresses and particular assets vary for each (test and mainNet) chain environment. #9748 addressed some of the issues in the original coreEval. #9999 showed what was needed for upgrading priceFeeds, which was completed by #9827. #10021 added some details on replacing scaledPriceAuthorities. ### Security Considerations N/A ### Scaling Considerations Addresses one of our biggest scaling issues. ### Documentation Considerations N/A ### Testing Considerations Thorough testing in a3p, and our testnets. #9886 discusses some testing to ensure Oracles will work with the upgrade. ### Upgrade Considerations See above

Chris-Hibbert force-pushed the 9584-upgradeVaults branch from 87bd81d to 97fa744 Compare August 1, 2024 23:06

dckc self-assigned this Aug 9, 2024

dckc force-pushed the 9584-up-vault-dc branch from 941b822 to 18f788e Compare August 9, 2024 21:54

Chris-Hibbert force-pushed the 9584-upgradeVaults branch 2 times, most recently from e69fe85 to 659c016 Compare August 12, 2024 22:37

dckc changed the title ~~test: verify liquidation after replacing price feeds~~ chore: parameterize price feed replacement (check liquidation) Aug 29, 2024

dckc force-pushed the 9584-up-vault-dc branch from 18f788e to aafae91 Compare September 3, 2024 20:33

dckc changed the base branch from 9584-upgradeVaults to 9928-priceFeeds September 3, 2024 20:34

dckc mentioned this pull request Sep 4, 2024

coreEval for replacing price feeds #9999

Closed

dckc force-pushed the 9584-up-vault-dc branch 2 times, most recently from 076c604 to f83e8c2 Compare September 9, 2024 19:01

dckc changed the base branch from 9928-priceFeeds to master September 9, 2024 19:03

Chris-Hibbert added the force:integration Force integration tests to run on PR label Sep 9, 2024

Chris-Hibbert and others added 13 commits September 10, 2024 12:35

refactor: rename e:upgrade-next to n:upgrade-next

84fb4f5

chore: setup f:replace-price-feeds

4eb168b

feat: start of a proposal for replacing priceFeeds

b88c330

test: PriceFeedDriver.refreshInvitations()

089bbfd

When a new price aggregator is launched, oracle operators need to accept new invitations.

test: export ATOM oracleAddresses from liquidation support

45c9927

test: thread $SLOGFILE thru liquidation setup

739c806

feat: makeProposalExtractor supports cliArgs

bbc08f2

chore: add parameterized builder to priceFeedSupport

51c1516

test: liquidation works with new price feeds, vaults, auctions

95059af

chore(vats): include priceAggregator in WellKnownContracts

5e55342

refactor: sanitizePathSegment

20f82af

chore: deploy-price-feeds core-eval script

3f2a983

chore: integrated price feed proposal

e618b56

dckc added 8 commits September 10, 2024 12:35

test: use updatePriceFeeds

5269856

fixup! feat: makeProposalExtractor supports cliArgs

13843eb

test: use integrated updatePriceFeeds with config

3e5378d

chore: align options between deploy-price-feed and scaled...

a9117e9

chore: prune priceFeedSupport.js

6f6c56b

fixup! test: use integrated updatePriceFeeds with config

710695b

feat: produce priceAuthority8400 signal when price feeds are updated

3dc7a9e

chore: wait for "price feeds all repaird" signal

3d6c4e7

dckc force-pushed the 9584-up-vault-dc branch from 0af884f to 3d6c4e7 Compare September 10, 2024 18:06

Chris-Hibbert reviewed Sep 10, 2024

View reviewed changes

Chris-Hibbert force-pushed the 9584-up-vault-dc branch from 3d6c4e7 to d0c83f8 Compare September 11, 2024 23:04

Chris-Hibbert assigned Chris-Hibbert and dckc and unassigned dckc and Chris-Hibbert Sep 11, 2024

Chris-Hibbert force-pushed the 9584-up-vault-dc branch from d0c83f8 to 3d6c4e7 Compare September 11, 2024 23:32

Chris-Hibbert mentioned this pull request Sep 11, 2024

9584 upgrade price feeds #10074

Merged

dckc mentioned this pull request Sep 19, 2024

integrate core evals for auction, vaults, and price feeds #10020

Closed

LuqiPan assigned Chris-Hibbert and unassigned dckc Sep 23, 2024

Chris-Hibbert closed this Sep 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: parameterize price feed replacement (check liquidation) #9827

chore: parameterize price feed replacement (check liquidation) #9827

dckc commented Aug 1, 2024 •

edited

Loading

dckc commented Aug 1, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Aug 1, 2024 •

edited

Loading

dckc commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024

dckc commented Sep 10, 2024

Chris-Hibbert left a comment

Chris-Hibbert Sep 10, 2024

turadg Sep 10, 2024

Chris-Hibbert Sep 10, 2024

dckc Sep 10, 2024

Chris-Hibbert Sep 10, 2024

Chris-Hibbert Sep 10, 2024

Chris-Hibbert Sep 10, 2024

Chris-Hibbert commented Sep 24, 2024

		oracleBrandProduce[name].reset();
		oracleBrandProduce[name].resolve(brand);

chore: parameterize price feed replacement (check liquidation) #9827

chore: parameterize price feed replacement (check liquidation) #9827

Conversation

dckc commented Aug 1, 2024 • edited Loading

Description

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

dckc commented Aug 1, 2024 • edited Loading

cloudflare-workers-and-pages bot commented Aug 1, 2024 • edited Loading

Deploying agoric-sdk with Cloudflare Pages

dckc commented Sep 3, 2024 • edited Loading

github-actions bot commented Sep 9, 2024

dckc commented Sep 10, 2024

Chris-Hibbert left a comment

Choose a reason for hiding this comment

Chris-Hibbert Sep 10, 2024

Choose a reason for hiding this comment

turadg Sep 10, 2024

Choose a reason for hiding this comment

Chris-Hibbert Sep 10, 2024

Choose a reason for hiding this comment

dckc Sep 10, 2024

Choose a reason for hiding this comment

Chris-Hibbert Sep 10, 2024

Choose a reason for hiding this comment

Chris-Hibbert Sep 10, 2024

Choose a reason for hiding this comment

Chris-Hibbert Sep 10, 2024

Choose a reason for hiding this comment

Chris-Hibbert commented Sep 24, 2024

dckc commented Aug 1, 2024 •

edited

Loading

dckc commented Aug 1, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Aug 1, 2024 •

edited

Loading

dckc commented Sep 3, 2024 •

edited

Loading