This repository has been archived by the owner on May 3, 2024. It is now read-only.
read instance board id from agoricNames #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
approved these changes
Aug 15, 2022
dckc
approved these changes
Aug 15, 2022
| import { unserializer } from 'utils/boardIdUnserializer'; | ||
| import { boardIdUnserializer } from 'utils/boardIdUnserializer'; |
There was a problem hiding this comment.
does this work? it doesn't need to be './utils/...?
There was a problem hiding this comment.
Yes, webpack looks for it under src by default because of https://github.com/Agoric/dapp-amm/blob/main/ui/jsconfig.json
Comment on lines
-26
to
-27
| // FIXME(https://github.com/Agoric/agoric-sdk/issues/5959): Read from chain. | ||
| const AMM_INSTANCE_BOARD_ID = 'board00917'; |
samsiegart
added a commit
that referenced
this pull request
Aug 17, 2022
* feat: use pool subscriptions (#23) * feat: use pool subscriptions * chore: bump react-scripts * chore: lint-fix * fix: fix liquidity validation * fix: fix lint (#25) * fix: RUN references * refactor: simplify getLogoForBrandPetname * Use smart wallet (#27) * smart wallet swap * track offers better * add/remove liquidity * read liquidity issuer ids * add todos for reading instance board id * fix: address feedback * add TODO for reading init stream better * read instance board id from agoricNames (#31) * fix build and pretty wallet connection (#33) Co-authored-by: Turadg Aleahmad <turadg@agoric.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: Agoric/agoric-sdk#5354
Depends on: