use Telescope-based cosmic-proto #240
Conversation
| @@ -1173,6 +1216,18 @@ | |||
| cosmjs-types "^0.8.0" | |||
| long "^4.0.0" | |||
|
|
|||
| "@cosmjs/proto-signing@^0.32.2": | |||
There was a problem hiding this comment.
nit: it seems like we now have 0.30.x and 0.32.x versions for many of the @cosmjs/* deps
There was a problem hiding this comment.
Good to raise. It looks to be mostly due to leapwallet pinning versions. We could use a resolution to override but that can be brittle.
I'll wait for @samsiegart 's input before merging. Also WRT test plan
There was a problem hiding this comment.
I tested the deployed preview and looks like it worked. I don't know much about the version thing, it's good to be aware of though, maybe upgrading leap elements would fix it.
| @@ -45,8 +45,3 @@ declare module '@agoric/inter-protocol/src/vaultFactory/math' { | |||
| declare module 'react-view-slider' { | |||
| export const ViewSlider; | |||
| } | |||
|
|
|||
| declare module '@agoric/cosmic-proto/swingset/query.js' { | |||
| @@ -12,14 +12,19 @@ const useSmartWalletFeeQuery = (rpc: string | null) => { | |||
| const fetchParams = async () => { | |||
| assert(rpc); | |||
| try { | |||
| const params = await querySwingsetParams(rpc); | |||
| const client = await agoric.ClientFactory.createRPCQueryClient({ | |||
There was a problem hiding this comment.
Remark: the wallet connection also makes its own query client, ideally at some point we could share between these two places somehow. I think the only main downside currently is an extra "status" query when you create an extra client.
0.4.0 builds with Telescope, which provides some client support we were hand rolling