Faucet Polling in E2E Tests #363
Conversation
Deploying agoric-dapp-inter-emerynet with
|
| Latest commit: |
256d924
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1a712796.agoric-dapp-inter-emerynet.pages.dev |
| Branch Preview URL: | https://usman-faucet-polling.agoric-dapp-inter-emerynet.pages.dev |
Deploying dapp-inter-test with
|
| Latest commit: |
256d924
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4e027f3d.dapp-inter-test.pages.dev |
| Branch Preview URL: | https://usman-faucet-polling.dapp-inter-test.pages.dev |
| if (transactionStatus === TRANSACTION_STATUS.NOT_FOUND) | ||
| // eslint-disable-next-line cypress/no-unnecessary-waiting | ||
| return cy.wait(2000).then(() => getStatus(txHash)); | ||
| else return cy.wrap(transactionStatus); |
There was a problem hiding this comment.
Should we use a maximum number of retires or some timeout to avoid an infinite loop? Is it possible that return cy.wait(2000).then(() => getStatus(txHash)); continues indefinitely?
There was a problem hiding this comment.
Cypress commands have a default timeout of 4 seconds so unless we have changed it, this shouldn't happen
There was a problem hiding this comment.
Command timeout is 6 minutes for testnets and 2 minutes with local chain. Would that be fine? I think we should have 4 or 5 retries. That would be enough to make the call invalid, I guess.
There was a problem hiding this comment.
I don't think we can confidentaly say that N number of retries should be enough to include a transaction in a block. I would say let's keep trying until the Cypress command timeout exceeds instead to get maximum retires in. What do you think?
There was a problem hiding this comment.
Okies. Let's see how tests perform with this change.
There was a problem hiding this comment.
I just feel that waiting 6 min for transaction status with testnets seems like an overkill
There was a problem hiding this comment.
Yes you have a valid point. But I would like to see how often do we timeout waiting for the transaction to complete. Maybe we will need to do something about that if it is frequent.
Description
Updated test to poll for transaction completion