ci: image parameterization via env variables #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabi-siddique
added
liquidation-testing
Deploying dapp-inter-test with
|
| Latest commit: |
2984151
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://81fe999a.dapp-inter-test.pages.dev |
| Branch Preview URL: | https://rs-passing-a-custom-image-fo.dapp-inter-test.pages.dev |
Deploying agoric-dapp-inter-emerynet with
|
| Latest commit: |
2984151
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7d5ede7c.agoric-dapp-inter-emerynet.pages.dev |
| Branch Preview URL: | https://rs-passing-a-custom-image-fo.agoric-dapp-inter-emerynet.pages.dev |
rabi-siddique
force-pushed
the
rs-passing-a-custom-image-for-agd
branch
from
3756f91
to
2984151
Compare
frazarshad
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to input a custom image name for E2E testing.
Previous Setup:
ghcr.io/agoric/agoric-3-proposalsfor E2E testing.tagfor this image during testing in CI via an input.The Issue:
ghcr.io/agoric/agoric-sdk:a3p-use-upgrade-next-20240911203722-bc66a5started being used for E2E testing, inu17.docker-composefile (as done in testing with u17 #365). This was not ideal.The Fix: