Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: downgrade cosmos-kit #101

Merged
merged 2 commits into from
Jan 17, 2025
Merged

build: downgrade cosmos-kit #101

merged 2 commits into from
Jan 17, 2025

Conversation

mujahidkay
Copy link
Member

@mujahidkay mujahidkay commented Jan 17, 2025

Closes: #98

This PR attempts to unbreak main by downgrading cosmos-kit to 2.8.5 as suggested by ui-tutorial repo

@mujahidkay mujahidkay requested a review from amessbee January 17, 2025 12:50
@mujahidkay mujahidkay self-assigned this Jan 17, 2025
@amessbee
Copy link
Contributor

I think I saw this resolution somewhere else as well. Not sure, if it's safe. Would defer to @samsiegart

@mujahidkay Any reason, this also fixes CI issues?

@amessbee amessbee requested a review from samsiegart January 17, 2025 13:21
@mujahidkay
Copy link
Member Author

I think I saw this resolution somewhere else as well. Not sure, if it's safe. Would defer to @samsiegart

@mujahidkay Any reason, this also fixes CI issues?

Why would it not be safe? This fixes everything. cosmos-kit is currently using this package.

@samsiegart
Copy link
Contributor

samsiegart commented Jan 17, 2025

Left a comment on #98 (comment) but I believe the issue to be the version of cosmos-kit that this project uses, not our ui-kit. I would try updating that version, or using the older 2.8.5 like the tutorial suggests.

@mujahidkay mujahidkay changed the title build: fix featherjs external dep via resolution build: bump cosmos-kit Jan 17, 2025
@mujahidkay mujahidkay changed the title build: bump cosmos-kit build: downgrade cosmos-kit Jan 17, 2025
@mujahidkay mujahidkay merged commit ef54a5e into main Jan 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dep @hexxagon/feather.js not Available on npm-registry
3 participants