use TypeScript #40
Merged
use TypeScript #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsiegart
reviewed
Nov 3, 2022
| import { useAtomValue } from 'jotai'; | ||
|
|
||
| import AssetListItem from 'components/AssetListItem'; | ||
| import ListItem from 'components/ListItem'; | ||
| import SkeletonListItem from 'components/SkeletonListItem'; | ||
| import { displayFunctionsAtom } from 'store/app'; | ||
|
|
||
| // Ambient | ||
| import '@agoric/ertp/src/types.js'; |
There was a problem hiding this comment.
Is it appropriate to use import type here?
There was a problem hiding this comment.
Ideally but the problem is the types needed are defined ambiently instead of in a module. We'll get there eventually but it's a lot more work Agoric/agoric-sdk#4560
src/store/app.ts
Outdated
| import '@agoric/ertp/src/types'; | ||
| import '@agoric/zoe/src/contractSupport'; | ||
| import '@agoric/wallet-backend/src/types'; | ||
| import { PursesJSONState } from '@agoric/wallet-backend'; |
There was a problem hiding this comment.
Does this have to be imported after the types?
There was a problem hiding this comment.
Not sure how line 11 got there. Maybe It should go back up to where it was as import type { PursesJSONState } from '@agoric/wallet-backend';
Deploying with
|
| Latest commit: |
1bba84e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a4544a82.dapp-psm.pages.dev |
| Branch Preview URL: | https://ta-import-types.dapp-psm.pages.dev |
samsiegart
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on recent work in Agoric/agoric-sdk#6500 to export types.
Where I'd like to get to is no need to manually define here any types here that come from agoric-sdk. There's more work to do but this at least drops
ertp.d.tsand makes imports easier by using .ts syntax.