Update and rename UIComponentsstart.md to index.md #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying documentation with
|
| Latest commit: |
693012d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://74bad44a.documentation-7tp.pages.dev |
| Branch Preview URL: | https://otoole-brendan-patch-4.documentation-7tp.pages.dev |
|
Cloudflare deployment logs are available here |
samsiegart
requested changes
May 17, 2024
There was a problem hiding this comment.
The "UI Components" under the nav menu links to https://otoole-brendan-patch-4.documentation-7tp.pages.dev/guides/UIComponentLibrary/UIComponentsstart.html which 404s, I think it should link to just https://otoole-brendan-patch-4.documentation-7tp.pages.dev/guides/UIComponentLibrary/ (just the path, not the full url with the github build link obviously)
Also, looks like the "Using a Custom Chain Provider" link is wrong, it should link to https://github.com/Agoric/ui-kit/tree/main/packages/react-components#using-a-custom-chainprovider
updated 'using a custom chain provider' URL at Sam's request
samsiegart
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content changes including adding Leap Elements, cleaning up page and linking Amount Input and Smart Wallet Provisioning