contract upgrade #968
Merged
contract upgrade #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dckc
requested review from
turadg,
erights,
LuqiPan,
Chris-Hibbert and
kbennett2000
Deploying with
|
| Latest commit: |
dad0201
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://02226528.documentation-7tp.pages.dev |
| Branch Preview URL: | https://dc-durable-upgrade.documentation-7tp.pages.dev |
dckc
force-pushed
the
dc-durable-upgrade
branch
from
17f858a to
3417f5a
Compare
Chris-Hibbert
requested changes
Feb 8, 2024
0xpatrickdev
reviewed
Feb 8, 2024
0xpatrickdev
reviewed
Feb 8, 2024
0xpatrickdev
reviewed
Feb 8, 2024
dckc
force-pushed
the
dc-durable-upgrade
branch
from
3417f5a to
dfb6c44
Compare
dckc
force-pushed
the
dc-durable-upgrade
branch
4 times, most recently
from
cbd9f3b to
515631d
Compare
erights
reviewed
Feb 10, 2024
main/guides/zoe/contract-upgrade.md
Outdated
|
|
||
| ::: details What happens if we don't use baggage? | ||
|
|
||
| When the contract instance is restarted, it gets a fresh [heap](../js-programming/#vats-the-unit-of-synchrony), so [ordinary heap state](./contract-basics.html#state) does not survive upgrade. This implementation does not persist the effect of `E(publicFacet).set(2)` from the first incarnation: |
There was a problem hiding this comment.
I think this should be converted to a rooms example. Similarly in the following paragraph.
main/guides/zoe/contract-upgrade.md
Outdated
| - Once the state is defined by the `init` function (3rd arg), properties cannot be added or removed. | ||
| - Values of state properties must be serializable. | ||
| - Values of state properties are hardened on assignment. | ||
| - You can replace the value of a state property (e.g. `state.zot = [...state.zot, 'last']`), and you can update stores (`state.players.set(1, player1)`), but you cannot do things like `state.zot.push('last')` nor `state.jot = { x: 1 }; state.jot.x = 2`. |
There was a problem hiding this comment.
It's unfortunate that state.jot = { x: 1 }; state.jot.x = 2 broke across a line for me. What do you think of making it a multiline expression to make it more apparent?
2 tasks
Chris-Hibbert
approved these changes
Feb 15, 2024
dckc
force-pushed
the
dc-durable-upgrade
branch
from
f0d8424 to
a594490
Compare
- set off governance for upgrade - cite other relevant docs publicFacet was a poor example of baggage key chore: simplify number|string to just number in state example chore: durable state snippet w/interface guard - regions for snippets - more concise style: avoid arrowParens build: add @agoric/zone for durability/upgrade snippets chore: use rooms in heap state example to match durable chore: include contract-upgrade in LHS TOC Co-authored-by: Chris Hibbert <Chris-Hibbert@users.noreply.github.com>
dckc
force-pushed
the
dc-durable-upgrade
branch
from
a594490 to
dad0201
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goal:
fixes #750
rendered:
Audience is dapp/contract devs, so the emphasis is on how to achieve it, not the theory of how the infrastructure works. @LuqiPan , @kbennett2000 I'm particularly interested to know if this brief account covers the subject well enough for you to get a working knowledge of it.
It lacks detail on interface guards. I propose to merge this as is and add those later. Opinions?
I started trying to make sure all the code snippets are really tested, but
makeZoeKitForTestdoesn't support upgrade, and it's not clear to me how to do bootstrap tests withmakeSwingsetTestKitfrom outside agoric-sdk; I have already spent probably too much time on tooling in #965.Testing considerations
Examples are not well tested due to the difficulty of landing...