feat: make chain-integration > cosmos-sdk links clickable #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xpatrickdev
commented
Feb 8, 2024
| @@ -36,15 +36,15 @@ agd version --long | |||
| # FAQ | |||
|
|
|||
| - How are transactions encoded? | |||
| https://docs.cosmos.network/v0.45/core/encoding.html | |||
| [https://docs.cosmos.network/v0.45/core/encoding.html](https://docs.cosmos.network/v0.45/core/encoding.html) | |||
There was a problem hiding this comment.
These links also work with v0.46, but 404 at v0.47 and main
dckc
reviewed
Feb 8, 2024
| - What data is needed to create a transaction (last block hash, nonce, sender public key, etc.)? | ||
| https://docs.cosmos.network/v0.45/core/transactions.html#transaction-generation | ||
| - What data is signed and how is that data obtained (for example truncated SHA256 of transaction data)? | ||
| https://docs.cosmos.network/v0.45/core/transactions.html#transaction-generation | ||
| [https://docs.cosmos.network/v0.45/core/transactions.html#transaction-generation](https://docs.cosmos.network/v0.45/core/transactions.html#transaction-generation) |
There was a problem hiding this comment.
Let's avoid urls-in-your-face, please:
Suggested change
| [https://docs.cosmos.network/v0.45/core/transactions.html#transaction-generation](https://docs.cosmos.network/v0.45/core/transactions.html#transaction-generation) | |
| [Transaction Generation](https://docs.cosmos.network/v0.45/core/transactions.html#transaction-generation) |
and likewise throughout.
There was a problem hiding this comment.
eb9064d (updated PR body with new After)
Deploying with
|
| Latest commit: |
c239499
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9e19a845.documentation-7tp.pages.dev |
| Branch Preview URL: | https://864-cosmos-sdk-tx-encoding-l.documentation-7tp.pages.dev |
dckc
approved these changes
Feb 9, 2024
- (sort of) closes #864, which claims these links do not work
0xpatrickdev
force-pushed
the
864-cosmos-sdk-tx-encoding-links
branch
from
eb9064d to
c239499
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After