Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: permissioned contract deployment with tooling #985

Merged
merged 11 commits into from
Mar 19, 2024
Merged

Conversation

dckc
Copy link
Member

@dckc dckc commented Mar 9, 2024

closes #917
closes #961
closes #931

rendered:

TODO:

  • detail on devnet deployment:
    • make a community post about what you're up to before deploying to devnet. Be sure to choose a novel and appropriate name for your contract during this MN-2 phase.
    • you're not expected to deploy example dapps as-is to devnet. They would collide in agoricNames.instance if everybody did that.

builds on some recent work in dapp-agoric-basics

Copy link

cloudflare-workers-and-pages bot commented Mar 10, 2024

Deploying documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: c954cbd
Status: ✅  Deploy successful!
Preview URL: https://7ae8ad3d.documentation-7tp.pages.dev
Branch Preview URL: https://dc-deploy-contract.documentation-7tp.pages.dev

View logs

Comment on lines 12 to 14
1. [Write JavaScript code to deploy the contract](./proposal.md).
2. [Declare the capabilities that the script requires](./permissions.md).
3. [Submit transactions to install and deploy the contract](./local-testnet.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question

These bullet points doesn't match up with the sidebar:

  1. the order doesn't match up
  2. the section names don't match up
Screenshot 2024-03-10 at 11 50 52 AM

Should they match?

main/guides/coreeval/proposal.md Outdated Show resolved Hide resolved
main/guides/coreeval/local-testnet.md Outdated Show resolved Hide resolved

<img src='../assets/cosgov-install-bundle.png' alt='Install Bundle screenshot' width="600" />

Then drop your permit and core eval script on the **CoreEval Proposal** tab:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick

You probably meant to add another newline before the tab below?

- **zoe**: the Zoe service.
**Note: this includes the right to install any available bundle and start instances of any available installation.**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

starting instances is widely accessible.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only if you have access to zoe, right?

I suppose every contract can do zcf.getZoeService(). hm.

@dckc dckc force-pushed the dc-deploy-contract branch from 190fd02 to 7373869 Compare March 18, 2024 06:06
based on dapp-agoric-basics

 - style: markdown lint
@dckc dckc force-pushed the dc-deploy-contract branch from 7373869 to 71f6d33 Compare March 18, 2024 06:09
@dckc dckc requested a review from sufyaankhan March 18, 2024 16:23
@dckc
Copy link
Member Author

dckc commented Mar 18, 2024

@sufyaankhan note changes to the list of documented bootstrap powers; for example, feeMintAccess is no longer discussed.

The example is now from dapp-agoric-basics. It used to be an example of adding an Inter Protocol PSM for a new token. But we now have cosgov.org tooling for that sort of thing. So it no longer seems worthwhile to document Inter Protocol powers: economicCommitteeCreatorFacet, econCharterKit, provisionPoolStartResult, psmKit. Inter Protocol is like KREAd or Crabble in this way: we don't document the bootstrap powers involved in deploying those here; we leave that to https://community.agoric.com/c/governance/core-eval/31

@dckc dckc marked this pull request as ready for review March 18, 2024 23:16
@dckc dckc requested review from Chris-Hibbert and ivanlei March 18, 2024 23:16
@dckc dckc merged commit fefb53d into main Mar 19, 2024
4 checks passed
@dckc dckc deleted the dc-deploy-contract branch March 19, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants