Skip to content
This repository has been archived by the owner on Nov 14, 2023. It is now read-only.

feat(subm): require testnet participant role #16

Merged
merged 3 commits into from
Aug 13, 2021
Merged

feat(subm): require testnet participant role #16

merged 3 commits into from
Aug 13, 2021

Conversation

dckc
Copy link
Member

@dckc dckc commented Aug 13, 2021

fixes #15

p.s. this is already deployed

 - add login failure page; don't just mysteriously go to /
 - fix Upload.strategy to distinguish failed login (4xx)
   from server error (5xx)
   - Upload.strategy: absorb .login(); push config to caller
 - put whole GuildMember in session info
   - TODO: display relevant parts
 - refactor: we only use pure parts of gcs-signed-urls,
             so go ahead and import it at module level
@dckc dckc requested a review from michaelfig August 13, 2021 16:32
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

subm/src/subm.js Show resolved Hide resolved
Co-authored-by: Michael FIG <mfig@agoric.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

submit tool: require testnet-participant / teammate role
2 participants