Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix e2e test failures #199

Merged
merged 4 commits into from
Nov 14, 2024
Merged

fix e2e test failures #199

merged 4 commits into from
Nov 14, 2024

Conversation

rabi-siddique
Copy link
Contributor

@rabi-siddique rabi-siddique commented Nov 14, 2024

Recently, the wallet app has been failing e2e tests. This started with the first test case involving setting up the Keplr wallet. The same test case is working fine in the other dapps. After inspecting for a while, I realized the issue was happening with the Chrome browser. More details in agoric-labs/synpress#53

Copy link

cloudflare-workers-and-pages bot commented Nov 14, 2024

Deploying wallet-app with  Cloudflare Pages  Cloudflare Pages

Latest commit: deac4c7
Status: ✅  Deploy successful!
Preview URL: https://caf5b2f3.wallet-app.pages.dev
Branch Preview URL: https://rs-fix-e2e-test-failures.wallet-app.pages.dev

View logs

Copy link

github-actions bot commented Nov 14, 2024

Cloudflare deployment logs are available here

@rabi-siddique
Copy link
Contributor Author

Test failure is a flake:

  1. should succeed in provisioning the new wallet

So merging it.

@rabi-siddique rabi-siddique merged commit aa68b14 into main Nov 14, 2024
2 of 3 checks passed
@rabi-siddique rabi-siddique deleted the rs-fix-e2e-test-failures branch November 14, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants