feat: add geoip based request blocking #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChakshuGautam
approved these changes
Jan 4, 2024
|
|
||
| if (country !== 'India') { | ||
| this.logger.verbose('Denying request from ip: ' + clientIp + ' country: ' + country) | ||
| throw new HttpException('Access Denied', HttpStatus.FORBIDDEN); |
There was a problem hiding this comment.
Can we respond saying that this app can only be accessed in XYZ region as an output? It can either be a header or a JSON response.
This was referenced Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the functionality to block requests based on geoip locations, initially we only allow requests from India and block all other requests. The geolocation service used right now is the one we have deployed at https://geoip.samagra.io/.
Changes
A new interceptor has been implemented in the file
src/interceptors/geoip.interceptor.tsand this interceptor has been registered in themain.tsfile as a global interceptor. Further a new package named@nestjs/axioshas been added in the service.How to test
Try sending requests from various IP address via IP spoofing.
Please consider using the closing keyword if the pull request is proposed to
fix an issue already created in the repository
(https://help.github.com/articles/closing-issues-using-keywords/)