Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time formatted automatically while typing #233

Closed
Mradmedamine opened this issue Oct 8, 2019 · 3 comments
Closed

time formatted automatically while typing #233

Mradmedamine opened this issue Oct 8, 2019 · 3 comments

Comments

@Mradmedamine
Copy link
Contributor

as described the issue of formatting while typing is still there
I was typing 8:3 => it becomes 8:03 before I finish typing
image

solution is in the ngxTimePicker Directive (input) = onInput should become (change)
Mradmedamine pushed a commit to Mradmedamine/ngx-material-timepicker that referenced this issue Oct 8, 2019
Bugfix time formatted automatically while typing (Agranom#233)
90ec7a5
@Agranom
Copy link
Owner

Agranom commented Oct 9, 2019

Do you see this bug on the demo page?

@Mradmedamine
Copy link
Contributor Author

Mradmedamine commented Oct 9, 2019 •
edited
Loading

I made my input field editable. I want to be able to set up time manually or using the timepicker.
There I have the problem. Although everything works fine the binding between the value and the timepicker the only issue is what I mentioned.

<input matInput formControlName="pmEndTime" min="11:00" [ngxTimepicker]="pmEndTP" [format]="24" [disableClick]="true" /> <ngx-material-timepicker-toggle matSuffix [for]="pmEndTP"></ngx-material-timepicker-toggle> <ngx-material-timepicker #pmEndTP></ngx-material-timepicker>

Agranom pushed a commit that referenced this issue Oct 12, 2019
@Mradmedamine @Agranom
Bugfix time formatted automatically while typing (#233) (#234)
6f97892
Agranom added a commit that referenced this issue Oct 12, 2019
@Agranom
#211, #233 (#238)
e133f12 
* issue211: ! updating hour and minute without clock interaction

* fix(append-to-input): change method type from private to public
@Agranom
Copy link
Owner

Agranom commented Oct 12, 2019

Fix is available in v5.2.1

@Agranom Agranom closed this as completed Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mradmedamine @Agranom