Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical disposition even on large screens #87

Closed
IlCallo opened this issue Dec 24, 2018 · 4 comments
Closed

Vertical disposition even on large screens #87

IlCallo opened this issue Dec 24, 2018 · 4 comments

Comments

@IlCallo
Copy link

IlCallo commented Dec 24, 2018

I assume that vertical layout is for smaller screens, while the horizontal one is for desktop-wide screens.
But there's a width waypoint after which timepicker displays vertical layout even if on wide screens.
Maybe a wrong media query with an upper bound which should not be there?

@Agranom
Copy link
Owner

Agranom commented Dec 25, 2018

A horizontal layout is for devices with a landscape orientation and the verical one is for others. I'll change some media query so that it will work as I described.

@IlCallo
Copy link
Author

IlCallo commented Dec 26, 2018

What do you mean with "landascape orientation"? Just the ones which declares themselves as landscape, or every display in which viewport width is greater than height?

@Agranom
Copy link
Owner

Agranom commented Dec 26, 2018

I'll make horizontal position for mobile devices with landscape orientation

Agranom added a commit that referenced this issue Dec 30, 2018
* bugfix/issue85: expose public_api

* bugfix/issue87: change orientation only for devices

* bugfix/issue86: centered dial time on 24-hours format

* update version
@Agranom
Copy link
Owner

Agranom commented Dec 30, 2018

Fixed. Update to the latest version.

@Agranom Agranom closed this as completed Dec 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants