Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Obsolete] millimeter per plot ; inch per plot #116

Closed
KrishnaTO opened this issue Oct 19, 2021 · 7 comments
Closed

[Obsolete] millimeter per plot ; inch per plot #116

KrishnaTO opened this issue Oct 19, 2021 · 7 comments
Assignees
Milestone

Comments

@KrishnaTO
Copy link
Contributor

AgrO term (ID and Label)
millimeter per plot
inch per plot

Reason for deprecation
Need to revisit due to ambiguous interpretation and definition not provided. Term is subclass of area density unit, but refers to non-weight unit per area (density being mass per volume).

Suggested term to consider
plot area?

Your nano-attribution (ORCID)
If you don't have an ORCID, you can sign up for one here

@celineaubert
Copy link
Contributor

Hi Krishna,
This unit is used to measure precipitation (in millimeter per plot of inch per plot). This is a height of water per area. It is an ambiguous unit, but widely used (if not always used to talk about precipitation) and totally different from plot area. If you are able to find a better class for it, please move it, but do not obsolete those terms.

@KrishnaTO
Copy link
Contributor Author

KrishnaTO commented Oct 21, 2021

Also need to determine total irrigation amount per plot = ~rain amount per plot + irrigation amount per plot

In order to measure the amount of water added, as desired in this term, the inputs are 'irrigation' (issue #5 ) and 'rain'
Thus, the addition of quantity metrics by each method is required:

water-based rainfall

  • Rain amount per plot

Irrigation

Then, we can determine the water amount per plot as the considered term expects (in inches and mm).

inch per plot

@KrishnaTO KrishnaTO added this to the Resolve ROBOT Issues milestone Oct 22, 2021
@KrishnaTO KrishnaTO self-assigned this Oct 22, 2021
@KrishnaTO KrishnaTO modified the milestones: Resolve ROBOT Issues , Release-Nov-5 Oct 28, 2021
@KrishnaTO KrishnaTO changed the title [Obsolete] millimeter per plot ; inch per plot millimeter per plot ; inch per plot Oct 30, 2021
@KrishnaTO
Copy link
Contributor Author

@celineaubert Please review if we should keep the synonym in irrigation water quantity

@celineaubert
Copy link
Contributor

no need to add mm/plot and inch/plot classes

  • total irrigation amount per plot = total irrigation water added during the experiment duration (rain water in not taken into account). Irrigation is done more than once during a cropping season, therefore agronomists measure ''irrigation amount'' for a single irrigation process and ''irrigation amount'' corresponding to all the irrigation processes done during the experiment.

KrishnaTO added a commit to KrishnaTO/agro that referenced this issue Nov 3, 2021
- changed label
- removed editor note
- revised definition
- added axioms
@KrishnaTO
Copy link
Contributor Author

In which case, should we obsolete the millimeter per plot and inch per plot units, in favour of unit suggestions from #5 ?

Units are: mm, m3, m3/ha (if it exists in UO)

@celineaubert
Copy link
Contributor

Hi Krishna, yes, sorry I forgot the classes were already existing in AgrO.

KrishnaTO added a commit to KrishnaTO/agro that referenced this issue Nov 4, 2021
deprecated in protege using OBI format
suggested redirect to updated [volume of irrigation water](http://purl.obolibrary.org/obo/AGRO_00000010)
@KrishnaTO
Copy link
Contributor Author

@celineaubert done, please review PR #136 for changes.

@KrishnaTO KrishnaTO changed the title millimeter per plot ; inch per plot [Obsolete] millimeter per plot ; inch per plot Nov 4, 2021
marieALaporte added a commit that referenced this issue Nov 5, 2021
Revised term annotations per issues #5 #116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants