Optimization about preference window

- Delete action and store of preference
  - because It don't need to manage globally.
  - unnecessary action can cause confuse.

app/actions/constant/actionTypes.js

@@ -1,9 +1,6 @@
 export const MODAL_OPEN = 'MODAL_OPEN';
 export const MODAL_CLOSE = 'MODAL_CLOSE';
 export const OPEN_BROWSER_WINDOW = 'OPEN_BROWSER_WINDOW';
-export const PREFERENCE_ALLOCATE_ID = 'PREFERENCE_ALLOCATE_ID';
-export const PREFERENCE_OPEN = 'PREFERENCE_OPEN';
-export const PREFERENCE_CLOSE = 'PREFERENCE_CLOSE';
 export const SET_HOT_KEY_SEARCH_WINDOW = 'SET_HOT_KEY_SEARCH_WINDOW';
 export const SET_INITIAL_STORE = 'SET_INITIAL_STORE';
 export const SET_LANGUAGE_ENGLISH = 'SET_LANGUAGE_ENGLISH';

app/main.js

@@ -1,7 +1,6 @@
 import { app } from 'electron';
 import store from 'store/storeMain';
 import saveData from 'main/utils/disk/saveData';
-import { preferenceClose } from 'actions/preference';
 import { widgetCloseWhole } from 'actions/widget';
 import { setInitialStore, setWhenQuitApp } from 'actions/setting';
 import { isOpenWidgetWhenStartSelector } from 'store/reducers/share/status/selectors';
@@ -13,6 +12,7 @@ import handlingSearchHotKey from 'main/utils/menu/handlingSearchHotKey';
 import { hotKeySearchWindowSelector } from 'store/reducers/share/config/selectors';
 import openAllWidgetStatusOpen from 'main/utils/window/openAllWidgetStatusOpen';
 import openReduxDevTools from 'main/utils/window/openReduxDevTools';
+import handleIPC from 'main/utils/handleIPC';
 import { autoUpdater } from 'electron-updater';
 
 const SAVE_SETTING_INTERVAL = 300000;
@@ -35,6 +35,7 @@ app.on('ready', () => {
   autoLaunchConfig();
   autoUpdater.checkForUpdatesAndNotify();
 
+  handleIPC();
   // config data
   setInterval(saveData, SAVE_SETTING_INTERVAL);
   store.dispatch(setInitialStore());
@@ -67,7 +68,6 @@ app.on('before-quit', () => {
   if (!isOpenWidgetWhenStart) {
     dispatch(widgetCloseWhole());
   }
-  dispatch(preferenceClose());
   dispatch(setWhenQuitApp());
   saveData();
 });

app/main/controllers/__tests__/preference.spec.js

@@ -1,7 +1,6 @@
 import { autoUpdater } from 'electron-updater';
 import { CancellationToken } from 'electron-builder-http';
 import * as TYPES from 'actions/constant/actionTypes';
-import * as openPreference from 'main/utils/window/openPreference';
 import * as autoLaunch from 'main/utils/window/autoLaunch';
 import store from 'store/storeMain';
 import createMenu from 'main/utils/menu/createMenu';
@@ -21,19 +20,6 @@ describe('test preference controller', () => {
     jest.clearAllMocks();
   });
 
-  it('should handle OPEN_PREFERENCE', () => {
-    const mockOpenPreference = jest.spyOn(openPreference, 'default');
-    mockOpenPreference.mockImplementation(jest.fn());
-    const mockAction = {
-      type: TYPES.PREFERENCE_OPEN,
-    };
-
-    preferenceController(mockAction);
-
-    expect(mockOpenPreference).toHaveBeenCalledTimes(1);
-    expect(mockOpenPreference).toHaveBeenCalledWith();
-  });
-
   it('should handle TOGGLE_OPEN_APP_WHEN_LOGIN', () => {
     const mockAutoLaunch = jest.spyOn(autoLaunch, 'default');
     mockAutoLaunch.mockImplementation(jest.fn());

app/main/controllers/preference.js

@@ -1,7 +1,6 @@
 import { autoUpdater } from 'electron-updater';
 import { CancellationToken } from 'electron-builder-http';
 import store from 'store/storeMain';
-import openPreference from 'main/utils/window/openPreference';
 import * as TYPES from 'actions/constant/actionTypes';
 import autoLaunch from 'main/utils/window/autoLaunch';
 import createMenu from 'main/utils/menu/createMenu';
@@ -18,10 +17,6 @@ let cancellationToken;
 const preferenceController = (action) => {
   const { type } = action;
   switch (type) { // eslint-disable-line default-case
-    case TYPES.PREFERENCE_OPEN: {
-      openPreference();
-      break;
-    }
     case TYPES.TOGGLE_OPEN_APP_WHEN_LOGIN: {
       autoLaunch();
       break;

app/main/utils/__tests__/handleIPC.spec.js

@@ -0,0 +1,22 @@
+import { ipcMain } from 'electron';
+import * as pref from 'main/utils/window/preference';
+import handleIPC from '../handleIPC';
+
+describe('test handleIPC', () => {
+  handleIPC();
+
+  it('should match number of whole handler', () => {
+    expect(ipcMain.on).toHaveBeenCalledTimes(1);
+  });
+
+  it('should call preference open', () => {
+    expect(ipcMain.on)
+      .toHaveBeenCalledWith('preference.open', expect.any(Function));
+
+    const openPreference = jest.spyOn(pref, 'openPreference');
+    const cb = ipcMain.on.mock.calls.filter(i => i[0] === 'preference.open')[0][1];
+
+    cb();
+    expect(openPreference).toHaveBeenCalledTimes(1);
+  });
+});

app/main/utils/__tests__/window/preference.spec.js

@@ -0,0 +1,46 @@
+import { BrowserWindow } from 'electron';
+import { PREFERENCE_PATH } from 'config';
+import { preference, openPreference } from 'main/utils/window/preference';
+
+
+describe('test window/preference', () => {
+  describe('when preference is null', () => {
+    afterAll(() => {
+      jest.clearAllMocks();
+    });
+    const mockWindow = new BrowserWindow();
+    BrowserWindow.mockImplementationOnce(() => mockWindow);
+
+    openPreference();
+
+    it('match preference', () => {
+      expect(preference).toEqual(mockWindow);
+    });
+
+    it('match loadURL', () => {
+      expect(preference.loadURL).toHaveBeenCalledTimes(1);
+      expect(preference.loadURL).toHaveBeenCalledWith(PREFERENCE_PATH);
+    });
+
+    it('match on.close', () => {
+      expect(mockWindow.on).toHaveBeenCalledTimes(1);
+      expect(mockWindow.on).toHaveBeenCalledWith('close', expect.any(Function));
+
+      expect(preference).toEqual(mockWindow);
+      const cb = mockWindow.on.mock.calls[0][1];
+
+      cb();
+      expect(preference).toEqual(null);
+    });
+  });
+
+  it('when preference is not null', () => {
+    const mockWindow = new BrowserWindow();
+    BrowserWindow.mockImplementationOnce(() => mockWindow);
+
+    openPreference();
+    openPreference();
+
+    expect(preference.show).toHaveBeenCalledTimes(1);
+  });
+});

app/main/utils/handleIPC.js

@@ -0,0 +1,10 @@
+import { ipcMain } from 'electron';
+import { openPreference } from 'main/utils/window/preference';
+
+function handleIPC() {
+  ipcMain.on('preference.open', () => {
+    openPreference();
+  });
+}
+
+export default handleIPC;

app/main/utils/menu/createMenu.js

@@ -2,7 +2,7 @@ import { app, Menu } from 'electron';
 import os from 'os';
 import store from 'store/storeMain';
 import { widgetMakeRequest } from 'actions/widget';
-import openPreference from 'main/utils/window/openPreference';
+import { openPreference } from 'main/utils/window/preference';
 import i18n from 'constants/i18n';
 
 // reference by https://electronjs.org/docs/api/menu#examples

app/main/utils/menu/trayMenuBar.js

@@ -10,7 +10,7 @@ import {
   TRAY_ICON_PATH,
 } from 'config';
 import i18n from 'constants/i18n';
-import openPreference from 'main/utils/window/openPreference';
+import { openPreference } from 'main/utils/window/preference';
 
 const trayMenuBar = menuBar({
   icon: TRAY_ICON_PATH,