forked from WebKit/WebKit
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Change the default oblique angle from 20deg to 14deg
Change the default oblique angle from 20deg to 14deg https://bugs.webkit.org/show_bug.cgi?id=248258 Reviewed by Myles C. Maxfield. This patch is to align Webkit with Blink / Chromium, Gecko / Firefox and Web-Specification. This is also part of Interop 2023 proposal [1]. [1] web-platform-tests/interop#64 Merge - https://chromium.googlesource.com/chromium/src/+/8bfd7d5770ec70f47e84b5cf33961b437a87c5a7 Web-Specification - http://w3c.github.io/csswg-drafts/css-fonts-4/#valdef-font-style-oblique-angle-90deg-90deg The specs refer to have default angle as 14deg - "The lack of an <angle> represents 14deg.". The imported test cases are leveraging font from Stephen Nixon using the Open Font License [2]. [2] https://github.com/arrowtype/vf-slnt-test/blob/main/fonts/license-recursive-OFL.txt#L3 * Source/WebCore/platform/graphics/FontSelectionAlgorithm.h: Update "italicThreshold" and "normalItalicValue" from 20deg to 14deg * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/slnt-variable.html: Added Test Case * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/slnt-variable-ref.html: Added Test Case Reference * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/slnt-variable-expected.html: Added Test Case Expectations * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/slnt-backslant-variable.html: Added Test Case * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/slnt-backslant-variable-ref.html: Added Test Case Reference * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/slnt-backslant-variable-expected.html: Added Test Case Expectations * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/at-font-face-matching-expected.txt: Updated Test Expectations * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/resources/FontStyleTest-slnt_backslant-VF.woff2 Added Test Font * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/resources/FontStyleTest-slnt-VF.woff2: Added Test Font * LayoutTests/fast/text/font-style-parse.html: Rebaselined * LayoutTests/fast/text/font-style-parse-expected.txt: Rebaselined * LayoutTests/platform/glib/TestExpectations: Add "Failure" Expectation with reference bug * LayoutTests/platform/ios/TestExpectations: Add "Failure" Expectation with reference bug * LayoutTests/platform/mac/TestExpectations: Add "Failure" Expectation with reference bug Canonical link: https://commits.webkit.org/258722@main
- Loading branch information
1 parent
20b003d
commit 28de25b
Showing
16 changed files
with
183 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+19.9 KB
...ted/w3c/web-platform-tests/css/css-fonts/variations/resources/FontStyleTest-slnt-VF.woff2
Binary file not shown.
Binary file added
BIN
+25 KB
...b-platform-tests/css/css-fonts/variations/resources/FontStyleTest-slnt_backslant-VF.woff2
Binary file not shown.
25 changes: 25 additions & 0 deletions
25
...ted/w3c/web-platform-tests/css/css-fonts/variations/slnt-backslant-variable-expected.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <meta charset="utf-8" /> | ||
| <title>CSS Test: Variable fonts with slant axis</title> | ||
| <style> | ||
| @font-face { | ||
| font-family: "slnt test font"; | ||
| src: url('resources/FontStyleTest-slnt_backslant-VF.woff2'); | ||
| font-style: oblique -15deg 15deg; | ||
| } | ||
| .test { | ||
| font-family: "slnt test font"; | ||
| font-size: 3em; | ||
| } | ||
| .slnt14 { | ||
| font-variation-settings: 'slnt' -14; | ||
| } | ||
| .backslant14 { | ||
| font-variation-settings: 'slnt' 14; | ||
| } | ||
| </style> | ||
| <p class="test backslant14">varfont</p> | ||
| <p class="test slnt14">varfont</p> | ||
| <p class="test slnt14">varfont</p> | ||
| <p class="test">varfont</p> |
25 changes: 25 additions & 0 deletions
25
...imported/w3c/web-platform-tests/css/css-fonts/variations/slnt-backslant-variable-ref.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <meta charset="utf-8" /> | ||
| <title>CSS Test: Variable fonts with slant axis</title> | ||
| <style> | ||
| @font-face { | ||
| font-family: "slnt test font"; | ||
| src: url('resources/FontStyleTest-slnt_backslant-VF.woff2'); | ||
| font-style: oblique -15deg 15deg; | ||
| } | ||
| .test { | ||
| font-family: "slnt test font"; | ||
| font-size: 3em; | ||
| } | ||
| .slnt14 { | ||
| font-variation-settings: 'slnt' -14; | ||
| } | ||
| .backslant14 { | ||
| font-variation-settings: 'slnt' 14; | ||
| } | ||
| </style> | ||
| <p class="test backslant14">varfont</p> | ||
| <p class="test slnt14">varfont</p> | ||
| <p class="test slnt14">varfont</p> | ||
| <p class="test">varfont</p> |
35 changes: 35 additions & 0 deletions
35
...sts/imported/w3c/web-platform-tests/css/css-fonts/variations/slnt-backslant-variable.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <meta charset="utf-8" /> | ||
| <title>CSS Test: Variable fonts with slant axis</title> | ||
| <link rel="help" href="https://www.w3.org/TR/css-fonts-4/#descdef-font-face-font-variation-settings" /> | ||
| <link rel="help" href="http://w3c.github.io/csswg-drafts/css-fonts-4/#valdef-font-style-oblique-angle-90deg-90deg" /> | ||
| <link rel="match" href="slnt-backslant-variable-ref.html"> | ||
| <meta name="assert" | ||
| content="For variable fonts, setting font-style to oblique or italic should apply forward and backward slant to variable axis."> | ||
| <!-- Fonts used in this test are authored by Stephen Nixon, more information in the link: | ||
| https://arrowtype.github.io/vf-slnt-test/index.html --> | ||
| <style> | ||
| @font-face { | ||
| font-family: "slnt test font"; | ||
| src: url('resources/FontStyleTest-slnt_backslant-VF.woff2'); | ||
| font-style: oblique -15deg 15deg; | ||
| } | ||
| .test { | ||
| font-family: "slnt test font"; | ||
| font-size: 3em; | ||
| } | ||
| .backslant { | ||
| font-style: oblique -14deg; | ||
| } | ||
| .oblique { | ||
| font-style: oblique; | ||
| } | ||
| .italic { | ||
| font-style: italic; | ||
| } | ||
| </style> | ||
| <p class="test backslant">varfont</p> | ||
| <p class="test oblique">varfont</p> | ||
| <p class="test italic">varfont</p> | ||
| <p class="test">varfont</p> |
21 changes: 21 additions & 0 deletions
21
...ests/imported/w3c/web-platform-tests/css/css-fonts/variations/slnt-variable-expected.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <meta charset="utf-8" /> | ||
| <title>CSS Test: Variable fonts with slant axis</title> | ||
| <style> | ||
| @font-face { | ||
| font-family: "slnt test font"; | ||
| src: url('resources/FontStyleTest-slnt-VF.woff2'); | ||
| font-style: oblique 0deg 15deg; | ||
| } | ||
| .test { | ||
| font-family: "slnt test font"; | ||
| font-size: 3em; | ||
| } | ||
| .slnt14 { | ||
| font-variation-settings: 'slnt' -14; | ||
| } | ||
| </style> | ||
| <p class="test slnt14">varfont</p> | ||
| <p class="test slnt14">varfont</p> | ||
| <p class="test">varfont</p> |
21 changes: 21 additions & 0 deletions
21
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/slnt-variable-ref.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <meta charset="utf-8" /> | ||
| <title>CSS Test: Variable fonts with slant axis</title> | ||
| <style> | ||
| @font-face { | ||
| font-family: "slnt test font"; | ||
| src: url('resources/FontStyleTest-slnt-VF.woff2'); | ||
| font-style: oblique 0deg 15deg; | ||
| } | ||
| .test { | ||
| font-family: "slnt test font"; | ||
| font-size: 3em; | ||
| } | ||
| .slnt14 { | ||
| font-variation-settings: 'slnt' -14; | ||
| } | ||
| </style> | ||
| <p class="test slnt14">varfont</p> | ||
| <p class="test slnt14">varfont</p> | ||
| <p class="test">varfont</p> |
31 changes: 31 additions & 0 deletions
31
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/slnt-variable.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <meta charset="utf-8" /> | ||
| <title>CSS Test: Variable fonts with slant axis</title> | ||
| <link rel="help" href="https://www.w3.org/TR/css-fonts-4/#descdef-font-face-font-variation-settings" /> | ||
| <link rel="help" href="http://w3c.github.io/csswg-drafts/css-fonts-4/#valdef-font-style-oblique-angle-90deg-90deg" /> | ||
| <link rel="match" href="slnt-variable-ref.html"> | ||
| <meta name="assert" | ||
| content="For variable fonts, 'oblique' and 'italic' keywords should work equivalent to 14 degrees of slant"> | ||
| <!-- Fonts used in this test are authored by Stephen Nixon, more information in the link: | ||
| https://arrowtype.github.io/vf-slnt-test/index.html --> | ||
| <style> | ||
| @font-face { | ||
| font-family: "slnt test font"; | ||
| src: url('resources/FontStyleTest-slnt-VF.woff2'); | ||
| font-style: oblique 0deg 15deg; | ||
| } | ||
| .test { | ||
| font-family: "slnt test font"; | ||
| font-size: 3em; | ||
| } | ||
| .oblique { | ||
| font-style: oblique; | ||
| } | ||
| .italic { | ||
| font-style: italic; | ||
| } | ||
| </style> | ||
| <p class="test oblique">varfont</p> | ||
| <p class="test italic">varfont</p> | ||
| <p class="test">varfont</p> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters