[Contracts] Contracts Service Final PR #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hub.com/Ahmad45123/workup into contracts-commands-cache-implementation
HusseinYasser
requested review from
aboueleyes,
Adam2431,
Kemosalamy and
Ahmad45123
as code owners
HusseinYasser
changed the title
Co-Authored-By: Adam Abouelmagd <Adam2431@users.noreply.github.com>
Co-Authored-By: Adam Abouelmagd <Adam2431@users.noreply.github.com>
HusseinYasser
requested review from
marsafy1,
Abdulaziz-Hassan,
AhmedNasserG and
Abdullah204
as code owners
|
since the payments changed their api and that jsut got merged into main, we need to pull from main and change the withDescription to withReferenceId |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Ahmad45123
approved these changes
May 19, 2024
There was a problem hiding this comment.
Why do you need this file? We needed it for SASI index. did you add an index ?
There was a problem hiding this comment.
iirc it was because the testing containers(the ones using docker) when running tests would cause an error as they were looking for a cassandra config file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ends contracts service.