Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds test project and ruby/cucumber type json output #39

Merged
merged 2 commits into from
Feb 4, 2017

Conversation

sidekickr
Copy link
Contributor

This is a large contribution I had talked with Ahmed about a few months ago. it got put on our back burner for some other work, but here it is.

We've created an official test project for Cucumberish, moving the features definition target and the CucumberishTest target from the examples project to this project. This cleans up examples to focus on being examples and gives a project for running unit tests against the library to check for regressions.

There is a failing test in the CucumberTest, but I confirmed that it was failing on the develop branch before generating the pull request.

Also in this submission (it would have been difficult to pull it out for a separate pull request) is JSON output for the test results in the format of ruby/cucumber. There are a few differences, in that we are using the cucumber JSON expanded formatter (https://gist.github.com/blt04/9866357) and are leaving out some of the output that doesn't make sense in objective-c.

I didn't do a full update on the README file. I'll work on that over the weekend and submit that separately.

…est results consistent with the Ruby/Cucumber JSON output formatter

Also changes naming convention of scenario outines as they appear in the test navigator to include the example text in the name.
Copy link
Collaborator

@brentleyjones brentleyjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small formatting things I noticed.

* @author Erik Call Reynolds
*@date, 16-11-15 12:11:00
*
* @brief creates the Cucumber JSON Output String similar to
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incomplete sentence


/*!
* @author Erik Call Reynolds
*@date, 16-11-15 12:11:00
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation

scenario.name = [self exampleScenarioNameForScenarioName:scenario.name exampleAtIndex:index];
scenario.keyword = (NSString *)kScenarioOutlineKeyword;

scenario.keyword = (NSString *)kScenarioOutlineKeyword;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tabs when it should be spaces.

scenario.examples = nil;
CCIExample * example = outline.examples.firstObject;
scenario.name = [self exampleScenarioNameForScenarioName:scenario.name exampleAtIndex:index example:example];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tabs when it should be spaces.

@@ -337,7 +348,9 @@ + (NSInvocation *)invocationForScenarioOutline:(CCIScenarioDefinition *)outline
}
}
}


[outline addOutlineChildScenario:scenario];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tabs when it should be spaces.

@Ahmed-Ali
Copy link
Owner

Guys... you are doing an amazing work over here!
It makes me feel guilty not to check it immediately :)
I mentioned it before (and mentioning it here in case you don't know about it @sidekickr), that I am having some personal obligations that might keep me so busy till the end of January.
Once I am done with these things, I will carefully check all the current issues and PRs and act on them immediately.
I am really sorry for not being able to do that immediately, and I can't thank you enough guys!
Please keep up this awesome work, and let's bring this library to its utmost value.

@sidekickr
Copy link
Contributor Author

updated the file formatting and documentation per comments by @brentleyjones

@brentleyjones
Copy link
Collaborator

This is really neat btw!

@Ahmed-Ali Ahmed-Ali merged commit 74f2662 into Ahmed-Ali:develop Feb 4, 2017
@Ahmed-Ali
Copy link
Owner

Has been merged to develop and going to master soon. Thanks guys for the amazing work!

@sidekickr sidekickr deleted the develop branch March 21, 2017 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants