-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds test project and ruby/cucumber type json output #39
Conversation
…est results consistent with the Ruby/Cucumber JSON output formatter Also changes naming convention of scenario outines as they appear in the test navigator to include the example text in the name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small formatting things I noticed.
* @author Erik Call Reynolds | ||
*@date, 16-11-15 12:11:00 | ||
* | ||
* @brief creates the Cucumber JSON Output String similar to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incomplete sentence
|
||
/*! | ||
* @author Erik Call Reynolds | ||
*@date, 16-11-15 12:11:00 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation
scenario.name = [self exampleScenarioNameForScenarioName:scenario.name exampleAtIndex:index]; | ||
scenario.keyword = (NSString *)kScenarioOutlineKeyword; | ||
|
||
scenario.keyword = (NSString *)kScenarioOutlineKeyword; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tabs when it should be spaces.
scenario.examples = nil; | ||
CCIExample * example = outline.examples.firstObject; | ||
scenario.name = [self exampleScenarioNameForScenarioName:scenario.name exampleAtIndex:index example:example]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tabs when it should be spaces.
@@ -337,7 +348,9 @@ + (NSInvocation *)invocationForScenarioOutline:(CCIScenarioDefinition *)outline | |||
} | |||
} | |||
} | |||
|
|||
|
|||
[outline addOutlineChildScenario:scenario]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tabs when it should be spaces.
Guys... you are doing an amazing work over here! |
updated the file formatting and documentation per comments by @brentleyjones |
This is really neat btw! |
Has been merged to develop and going to master soon. Thanks guys for the amazing work! |
This is a large contribution I had talked with Ahmed about a few months ago. it got put on our back burner for some other work, but here it is.
We've created an official test project for Cucumberish, moving the features definition target and the CucumberishTest target from the examples project to this project. This cleans up examples to focus on being examples and gives a project for running unit tests against the library to check for regressions.
There is a failing test in the CucumberTest, but I confirmed that it was failing on the develop branch before generating the pull request.
Also in this submission (it would have been difficult to pull it out for a separate pull request) is JSON output for the test results in the format of ruby/cucumber. There are a few differences, in that we are using the cucumber JSON expanded formatter (https://gist.github.com/blt04/9866357) and are leaving out some of the output that doesn't make sense in objective-c.
I didn't do a full update on the README file. I'll work on that over the weekend and submit that separately.