Skip to content
This repository has been archived by the owner on Jan 15, 2021. It is now read-only.

Focus on dropdown using Tab highlights dropdown list #156

Closed
kailash-joshi opened this issue Jul 4, 2019 · 1 comment · Fixed by #159
Closed

Focus on dropdown using Tab highlights dropdown list #156

kailash-joshi opened this issue Jul 4, 2019 · 1 comment · Fixed by #159
Labels
released

Comments

@kailash-joshi
Copy link

kailash-joshi commented Jul 4, 2019 •
edited by Aidurber
Loading

picky

Version

"react-picky": "^4.4.5"

Here's what went wrong:

When i land on dropdown from other element(say input box), react-picky is highlighted but the dropdown list is also highlighted without showing the list.
Attaching the screenshot for better understanding

Example

Create a Code Sandbox, you can fork this: Demo Picky
Aidurber added a commit that referenced this issue Jul 8, 2019
@Aidurber
fix(Accessibility): Dropdown is tab selectable when hidden
dba2908 
Dropdown should not be tab selectable when hidden

fix #156
@Aidurber Aidurber mentioned this issue Jul 8, 2019
Merged
Aidurber added a commit that referenced this issue Jul 8, 2019
@Aidurber
fix(Accessibility): Dropdown is tab selectable when hidden
e14ffd6 
Dropdown should not be tab selectable when hidden

fix #156
@Aidurber
Copy link
Owner

Aidurber commented Jul 8, 2019

🎉 This issue has been resolved in version 4.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Accessibility): Dropdown is tab selectable when hidden Aidurber/react-picky
2 participants
@Aidurber @kailash-joshi