This repository has been archived by the owner on Jan 15, 2021. It is now read-only.
fix: 🐛 select all state correctly reflected after rerendering #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the number of options increases when rerendering but the number of selected values stays the same, Picky should not report that all values are selected. This change adds additional checks to see if the number of options changes between rerenders and sets the state accordingly. ✅ Closes: #134
|
Awesome, thanks for this @randymorris, I'll merge when I finish work. |
|
🎉 This PR is included in version 4.4.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the number of options increases when rerendering but the number of
selected values stays the same, Picky should not report that all values
are selected. This change adds additional checks to see if the number
of options changes between rerenders and sets the state accordingly.
✅ Closes: #134
Note