This repository has been archived by the owner on Dec 31, 2020. It is now read-only.
support for ordering dependant items #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox date, time input types partial support starting from Firefox 57
It appears that due to the recent change from 2018 to 2019, there is one additional year in the select list, which caused the unit tests to fail. Signed-off-by: Lucian <lucian.buzzo@gmail.com>
…1123) * add del button functionality * delete unnecesary console.logs * fix tests * remove unnecesary console.log * Fix disappearing key-value pair and repair delete button * Add .vscode to gitignore * fix tests * Make test work for select/radio button * Add test cases * Remove one file from PR and one helper function * Add one classname for value input * remove accidentally added .vscode * linted codebase * remove inline styles, make use of bootstrap 3 styles and fix related tests * revert changes to .gitignore
This keeps biting me.
Change `div` to `ul`, update react key
* ObjectField passes readonly & disabled prop to template * Update README
…1105) * Clear ajv errors before validate it prevent persisting not wanted errors * rjsf-team#1104 Add link to issue on code
* fix typo in css code * Give ids to array fields and object fields, give "root" id to the topmost fieldset
* move array item from index to newIndex * formating * moved reordering to a function * adds test for array sorting
* Add preliminary support for the anyOf keyword This change introduces support for the `anyOf` keyword. The keyword is NOT supported in arrays (using the `items` keyword). Options provided in the `anyOf` keyword are rendered using a new component called `AnyOfField` this can be overridden with a custom field using the `fields` property. Signed-off-by: Lucian <lucian.buzzo@gmail.com> * Refactor unnecessary .map * Change selected option based on form data * Update README * Update README FAQ * Share prop types between fields
Signed-off-by: Lucian <lucian.buzzo@gmail.com>
* Allow boolean option label overrides with oneOf schema * Add oneOf RadioWidget playground sample * Document oneOf RadioWidget usage * Allow boolean enum options to be re-ordered for consistency with oneOf behavior
* rjsf-team#838 return schemaPath in transformErrors * rjsf-team#818 document structure of errors object in transformErrors * fix: take into account ajv bug * doc: re-add doc for transformErrors
* Basic support for 'nullable' types Modifies the implementation of `getSchemaType` so that when a property has a type of `[<any>, 'null']`, then `<any>` will be passed. This allows the library to render and validate the field correctly. For the sake of simplicity, this change does not attempt any further assumptions, coercions or transformations. References rjsf-team#465 * Add some test cases to `getSchemaType` spec * Add FAQ entry detailing nullable type behaviour * Add Playground example for nullable field * Tweak FAQ entry wording and fix typo Co-Authored-By: warrenseymour <warren@fountainhead.tech> * Correct example in FAQ entry Co-Authored-By: warrenseymour <warren@fountainhead.tech>
* rjsf-team#804 - Bug Fix - Empty divs are created * rjsf-team#804 - Bug Fix - Empty divs are created - Refactoring
rjsf-team#814) * Removed throwing error when there's an extraneous property in ui:order * Adding tests form orderProperties() * Updated ObjectField tests to test extraneous properties handling in order list * fix: keep order warning
…f-team#1234) * Fix rjsf-team#1233 : Exclude File object from isObject detection * Update test name Co-Authored-By: oterral <oterral@users.noreply.github.com>
Fixes rjsf-team#1239. _(Message COC002)_
* use select widget to render oneOf / anyOf control * pass more props to widget * change schema type to number * get uiOptions to pass to widget * do not pass props to custom widget in test * update tests to actually pass custom widget
* Accept custom string formats via `additionalFormats` prop Follow AJV extension pattern established for meta schemas and passthrough to AJV's addFormat method * Wire additionalFormats prop * additionalFormats → customFormats * Fix and test custom format prop updates * Update docs/validation.md Co-Authored-By: pushred <eric@pushred.co>
* Add NullField * Always set the formData to null for a null field * Don't overwrite existing data * Use central fields propTypes
* fix: console warn on unknown format errors instead of showing an error * fix: default to default widget if string format is not found * test: update tests
…ber() (rjsf-team#1269) * Make numbers nullable by allowing null values to be echoed from asNumber() * fix: revert package-lock changes
) * Support `readOnly` property from draft-handrews-json-schema-validation-01 * Fix failing test * Add note in docs about using the readOnly property * Update to be consistent with the changes done in commit 497620f
…schema-form into mozilla-services-master
bytnar
changed the title
ddknapik
approved these changes
May 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Mainly to get support to ordering dependant items
rjsf-team#814
Checklist
npm run cs-formaton my branch to conform my code to prettier coding style