Fix an issue where the UI would not work due to getting the wrong roo…

…t element
AirenSoft · Jan 11, 2022 · 92551c0 · 92551c0
1 parent e7a7004
commit 92551c0
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 15 deletions.
diff --git a/dist/ovenplayer.js b/dist/ovenplayer.js
diff --git a/dist/ovenplayer.js.map b/dist/ovenplayer.js.map
diff --git a/src/js/ovenplayer.js b/src/js/ovenplayer.js
@@ -19,15 +19,6 @@ function ovenPlayerFactory() {
 
         const playerInstance = OvenPlayerSDK.create(player.getMediaElementContainer(), options);
 
-        Object.assign(playerInstance, {
-            getContainerElement: function () {
-                return containerElement;
-            },
-            getContainerId: function () {
-                return containerElement.id;
-            }
-        });
-
         player.setApi(playerInstance);
 
         return playerInstance;

diff --git a/src/js/utils/likeA$.js b/src/js/utils/likeA$.js
@@ -13,6 +13,9 @@ import dom from 'utils/polyfills/dom.js';
 
 const La$ = function(selectorOrElement){
     const that = {};
+
+    let $element = null;
+
     const returnNode = function($element , selector){
         let nodeList =  $element.querySelectorAll(selector);
         if(nodeList.length > 1){
@@ -23,8 +26,6 @@ const La$ = function(selectorOrElement){
 
     };
 
-    let $element = "";
-
     if( _.isElement(selectorOrElement) || _.every(selectorOrElement, function(item){return _.isElement(item)})){
         $element = selectorOrElement;
     }else if(selectorOrElement === "document"){
@@ -158,7 +159,7 @@ const La$ = function(selectorOrElement){
     };
 
     that.offset = () =>{    //IE8+
-        var rect = $element.getBoundingClientRect();
+        const rect = $element.getBoundingClientRect();
 
         return {
             top: rect.top + document.body.scrollTop,

diff --git a/src/js/view/view.js b/src/js/view/view.js
@@ -30,7 +30,7 @@ import {
 import '../../stylesheet/ovenplayer.less';
 
 const View = function($container){
-    let viewTemplate = "", controls = "", helper = "", $playerRoot, contextPanel = "", api = "", autoHideTimer = "", playerState = STATE_IDLE;
+    let viewTemplate = "", controls = "", helper = "", $playerRoot, contextPanel = "", api = null, autoHideTimer = "", playerState = STATE_IDLE;
     let isShiftPressed = false;
     let panelManager = PanelManager();
     let screenSize = "";
@@ -311,6 +311,14 @@ const View = function($container){
     that.setApi = (playerInstance) => {
         api = playerInstance;
 
+        api.getContainerElement = () => {
+            return $playerRoot.get();
+        };
+
+        api.getContainerId = () => {
+            return $playerRoot.get().id;
+        };
+
         api.on(READY, function(data) {
 
             if(!controls){