New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shrink browser build by removing `async` and requiring Lodash piecemeal #76

Merged

kasrak merged 1 commit into master from shrinkBrowserBuildSizeByHalf

Nov 28, 2018

Contributor

EvanHahn commented Nov 27, 2018 •

edited

Loading

The minified size went from 216 KB to 122 KB. Did three things:

Instead of _.isArray, we use things like var isArray = require('lodash/isArray')
Removed the async package; we weren't using it for much
Replaced some of Lodash's methods with native methods (like _.isUndefined(x) with x === void 0.

See #75.

EvanHahn force-pushed the shrinkBrowserBuildSizeByHalf branch 3 times, most recently from ad194d0 to 8b8183f Compare

November 28, 2018 16:11


          Shrink browser build by removing async and requiring Lodash piecemeal

b2311d5

EvanHahn force-pushed the shrinkBrowserBuildSizeByHalf branch from 8b8183f to b2311d5 Compare

November 28, 2018 17:12

kasrak approved these changes

View reviewed changes

kasrak merged commit 933a08f into master

EvanHahn deleted the shrinkBrowserBuildSizeByHalf branch

November 28, 2018 18:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet