Fix behavior for default-only tagged entity fields #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## aiven-anton/fix-nullable-entity-field #102 +/- ##
======================================================================
Coverage 96.69% 96.69%
======================================================================
Files 14 14
Lines 997 997
Branches 141 141
======================================================================
Hits 964 964
Misses 29 29
Partials 4 4 ☔ View full report in Codecov by Sentry. |
Base automatically changed from
aiven-anton/fix-nullable-entity-field
to
main
December 5, 2023 13:29
This enables the Java tests for the last non-record entity: FetchRequest. This was previously failing because on the Java side, the ReplicaState field tagged field is omitted when all of the nested fields are equal to defaults. Because our logic already has the correct behavior in general for tagged fields, all that was needed here was to make such parent fields have a default value. We detect when we can set a default by checking if the nested entity has default values for all of its fields.
aiven-anton
force-pushed
the
aiven-anton/fix-tagged-entity-field-all-defaults
branch
from
b097bc9 to
f1d25de
Compare
giuseppelillo
approved these changes
Dec 11, 2023
giuseppelillo
deleted the
aiven-anton/fix-tagged-entity-field-all-defaults
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the Java tests for the last non-record entity: FetchRequest. This was previously failing because on the Java side, the ReplicaState field tagged field is omitted when all of the nested fields are equal to defaults.
Because our logic already has the correct behavior in general for tagged fields, all that was needed here was to make such parent fields have a default value. We detect when we can set a default by checking if the nested entity has default values for all of its fields.
Partially addresses #100.