feature: Refine exposed protocol types #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiven-anton
force-pushed
the
aiven-anton/feature-expose-improved-header-and-payload-types
branch
from
0540fd4
to
ab35db6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
==========================================
+ Coverage 96.57% 96.65% +0.07%
==========================================
Files 14 14
Lines 994 1016 +22
Branches 138 138
==========================================
+ Hits 960 982 +22
Misses 26 26
Partials 8 8 ☔ View full report in Codecov by Sentry. |
aiven-anton
commented
Dec 14, 2023
This comment was marked as resolved.
This comment was marked as resolved.
aiven-anton
force-pushed
the
aiven-anton/feature-expose-improved-header-and-payload-types
branch
from
ab35db6
to
5e5ea57
Compare
matyaskuti
reviewed
Jan 31, 2024
jjaakola-aiven
previously approved these changes
Feb 1, 2024
By refining the exposed protocol types to include unions types for the different kinds of headers, we allow typing at call-sites to work smoother. This also enables using exhaustiveness checking in a place where it wasn't possible before, when matching the type of an entity's header schema. See the replaced NotImplementedError in the diff for reference.
aiven-anton
force-pushed
the
aiven-anton/feature-expose-improved-header-and-payload-types
branch
from
79ae094
to
165de2d
Compare
jjaakola-aiven
approved these changes
Feb 5, 2024
jjaakola-aiven
deleted the
aiven-anton/feature-expose-improved-header-and-payload-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By refining the exposed protocol types to include unions types for the different kinds of headers, we allow typing at call-sites to work smoother. This also enables using exhaustiveness checking in a place where it wasn't possible before, when matching the type of an entity's header schema. See the replaced NotImplementedError in the diff for reference.