-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise BufferUnderflow when too few bytes to parse #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiven-anton
force-pushed
the
aiven-anton/handle-buffer-underflows
branch
2 times, most recently
from
January 29, 2024 15:28
065ce9a
to
9ac9098
Compare
jjaakola-aiven
previously approved these changes
Jan 31, 2024
aiven-anton
force-pushed
the
aiven-anton/handle-buffer-underflows
branch
from
January 31, 2024 14:37
9ac9098
to
b30e11e
Compare
jjaakola-aiven
previously approved these changes
Feb 1, 2024
aiven-anton
force-pushed
the
aiven-anton/handle-buffer-underflows
branch
from
February 2, 2024 15:17
b30e11e
to
1c62db3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
==========================================
+ Coverage 96.57% 96.60% +0.02%
==========================================
Files 14 14
Lines 994 1001 +7
Branches 138 139 +1
==========================================
+ Hits 960 967 +7
Misses 26 26
Partials 8 8 ☔ View full report in Codecov by Sentry. |
aiven-anton
force-pushed
the
aiven-anton/handle-buffer-underflows
branch
from
February 5, 2024 08:27
f9df933
to
fa10c19
Compare
jjaakola-aiven
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.