chore: combine and sort imports #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjaakola-aiven
commented
Jan 31, 2024
pyproject.toml
Outdated
| combine-as-imports = true | ||
| lines-between-types = 1 |
There was a problem hiding this comment.
This is the change.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
=======================================
Coverage 96.69% 96.69%
=======================================
Files 14 14
Lines 999 999
Branches 140 140
=======================================
Hits 966 966
Misses 29 29
Partials 4 4 ☔ View full report in Codecov by Sentry. |
aiven-anton
reviewed
Jan 31, 2024
jjaakola-aiven
force-pushed
the
jjaakola-aiven-combine-and-sort-imports
branch
from
7cfe52f to
0deb1ad
Compare
aiven-anton
approved these changes
Jan 31, 2024
|
Confirmed this is failing with same set of tests as main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.