Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle null arrays #121

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Handle null arrays #121

merged 1 commit into from
Feb 2, 2024

Conversation

giuseppelillo
Copy link
Contributor

@giuseppelillo giuseppelillo commented Jan 31, 2024

Implement support for null arrays.

@giuseppelillo giuseppelillo force-pushed the giuseppelillo/handle-null-arrays branch from f5bc4cf to adecce0 Compare January 31, 2024 16:23
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (00d99f0) 96.85% compared to head (995a30f) 96.02%.

Files Patch % Lines
src/kio/serial/writers.py 50.00% 3 Missing and 2 partials ⚠️
src/kio/serial/readers.py 66.66% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   96.85%   96.02%   -0.84%     
==========================================
  Files          14       14              
  Lines        1018     1031      +13     
  Branches      140      144       +4     
==========================================
+ Hits          986      990       +4     
- Misses         28       33       +5     
- Partials        4        8       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giuseppelillo giuseppelillo force-pushed the giuseppelillo/handle-null-arrays branch 7 times, most recently from 7e64616 to ae349e1 Compare February 1, 2024 13:41
@giuseppelillo giuseppelillo marked this pull request as ready for review February 1, 2024 13:53
@giuseppelillo giuseppelillo requested review from a team as code owners February 1, 2024 13:53
Copy link
Collaborator

@aiven-anton aiven-anton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 👍 I left a single comment that I think should be addressed.

src/kio/serial/writers.py Outdated Show resolved Hide resolved
src/kio/serial/_introspect.py Show resolved Hide resolved
@giuseppelillo giuseppelillo force-pushed the giuseppelillo/handle-null-arrays branch from ae349e1 to 995a30f Compare February 2, 2024 12:40
@aiven-anton aiven-anton enabled auto-merge (squash) February 2, 2024 12:44
@aiven-anton aiven-anton merged commit ee6e5b1 into main Feb 2, 2024
12 checks passed
@aiven-anton aiven-anton deleted the giuseppelillo/handle-null-arrays branch February 2, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants