Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Implement basic support for record fields #122

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

aiven-anton
Copy link
Collaborator

@aiven-anton aiven-anton commented Jan 31, 2024

Issues to be discussed:

  • This does not enable the Java compatibility tests for entities with records.
    These are currently failing as Hypothesis generates random bytes for the records fields. We should most likely introduce a RecordsBytes type and teach Hypothesis to generate some static record batch for this to begin with (no need to have more intricate knowledge of record batches yet).
  • Java compatibility tests are failing when record batch fields are None. Why?
  • It's probably fine to merge the integration test with @xfail. It needs to be solved at some point, but merging it doesn't make the current situation any worse.

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (07553df) 96.86% compared to head (aa44fe7) 96.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
- Coverage   96.86%   96.85%   -0.02%     
==========================================
  Files          14       14              
  Lines        1022     1018       -4     
  Branches      142      140       -2     
==========================================
- Hits          990      986       -4     
  Misses         28       28              
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aiven-anton aiven-anton marked this pull request as ready for review February 1, 2024 13:23
@aiven-anton aiven-anton requested review from a team as code owners February 1, 2024 13:23
@giuseppelillo giuseppelillo enabled auto-merge (squash) February 1, 2024 13:24
@giuseppelillo giuseppelillo merged commit 9880dd7 into main Feb 1, 2024
12 checks passed
@giuseppelillo giuseppelillo deleted the aiven-anton/feature/non-parsed-records branch February 1, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants