feature: Build schema on upstream version 3.7.0 #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiven-anton
force-pushed
the
aiven-anton/3.7.0
branch
from
7654f3d
to
8fef14f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
aiven-anton
changed the title
Base automatically changed from
aiven-anton/remove-version-from-schema-docstrings
to
main
May 31, 2024 12:27
aiven-anton
force-pushed
the
aiven-anton/3.7.0
branch
from
8fef14f
to
ff4060c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 822 822
Branches 132 132
=========================================
Hits 822 822 ☔ View full report in Codecov by Sentry. |
Explanation: it seems we again differed with upstream in determining what the "default" value of a complex field is. In this case, Apache Kafka thinks a tagged field of a collection of nested entities, should implicitly default to the empty collection. Previously this was guarded by inspecting the "ignorable" value of fields, but this behavior was not consistent with the new v10 Produce response.
aiven-anton
force-pushed
the
aiven-anton/3.7.0
branch
from
4623bfd
to
a017a86
Compare
giuseppelillo
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.