Fix CreateTopicsResponse generation #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanyu
force-pushed
the
ivanyu/fix-CreateTopicsResponse
branch
from
10e8c6d
to
873d8c6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 13 13
Lines 951 951
Branches 132 132
=======================================
Hits 939 939
Misses 7 7
Partials 5 5 ☔ View full report in Codecov by Sentry. |
aiven-anton
reviewed
Nov 16, 2023
ivanyu
force-pushed
the
ivanyu/fix-CreateTopicsResponse
branch
3 times, most recently
from
d043dad
to
e13a2c5
Compare
The key is in handling optionality and defaults of primitive types correctly.
ivanyu
force-pushed
the
ivanyu/fix-CreateTopicsResponse
branch
from
e13a2c5
to
2acc6ec
Compare
aiven-anton
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key is in handling optionality and defaults of primitive types correctly.