Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪸 ui-rewrite: Add pre-commit hooks linting, formatting, testing #112

Closed
programmiri opened this issue Oct 19, 2022 · 0 comments · Fixed by #129
Closed

🪸 ui-rewrite: Add pre-commit hooks linting, formatting, testing #112

programmiri opened this issue Oct 19, 2022 · 0 comments · Fixed by #129
Assignees
@programmiri
Labels
triaged Acknowledged

Comments

@programmiri
Copy link
Contributor

programmiri commented Oct 19, 2022 •
edited
Loading

Goal

  • When comiting changes to coral a pre-commit hook ensures that every code has to comply to agreed conventions and passes all test.

Details

  • we use husky
@programmiri programmiri self-assigned this Oct 20, 2022
@programmiri programmiri mentioned this issue Oct 20, 2022
Merged
SmuliS added a commit that referenced this issue Oct 24, 2022
@SmuliS
feat[coral]: extract tsc into its own pre-commit check
2fcb628 
lint-staged passes changed filenames as argument. If files
are passed as argument `tsc` does not use tsconfig.json,
but CLI inline config.

Also run plain prettier and eslint commands with lint-staged.
the `pnpm lint` does not use files as argument.

Refers: #112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@programmiri programmiri

Labels
triaged Acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add precommit hook Aiven-Open/klaw
1 participant
@programmiri