Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪸 ui-rewrite: Add setup for styling #113

Closed
programmiri opened this issue Oct 19, 2022 · 1 comment
Closed

🪸 ui-rewrite: Add setup for styling #113

programmiri opened this issue Oct 19, 2022 · 1 comment
Assignees
@programmiri
Labels
triaged Acknowledged

Comments

@programmiri
Copy link
Contributor

Goal

  • Devs can develop a static React component/view using aiven design system and CSS modules to enhance / overwrite styles.
  • We have the App.tsx showing the heading "Hello Klaw" in typo based on aiven design system but the color is overwritten in hotpink.

Note

In a next iteration we'll implement css variables based on the design system token.
@programmiri programmiri self-assigned this Oct 21, 2022
@programmiri
Copy link
Contributor Author

programmiri commented Oct 21, 2022 •
edited
Loading

First branch to include the aiven component library: https://github.com/aiven/klaw/tree/113-ui-rewrite-add-setup-for-styling

@programmiri programmiri mentioned this issue Oct 21, 2022
Merged
SmuliS added a commit that referenced this issue Oct 21, 2022
@SmuliS
feat[coral]: Showcase css modules with example
4c3928c 
CSS Modules work by default.

Refers: #113
@SmuliS SmuliS mentioned this issue Oct 21, 2022
Merged
SmuliS added a commit that referenced this issue Oct 21, 2022
@SmuliS
feat[coral]: Showcase css modules with example
122050c 
CSS Modules work by default.

Refers: #113
SmuliS added a commit that referenced this issue Oct 21, 2022
@SmuliS
feat[coral]: Add support for css modules in unittests
f45938a 
Implemented as described in:
https://jestjs.io/docs/webpack#mocking-css-modules

Refers: #113
SmuliS added a commit that referenced this issue Oct 21, 2022
@SmuliS
feat[coral]: Showcase css modules with example
b3a39a1 
CSS Modules work by default.

Refers: #113
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@programmiri programmiri

Labels
triaged Acknowledged
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

113-ui-rewrite-add-setup-for-styling Aiven-Open/klaw
1 participant
@programmiri