Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Schema Promotion button using new TopicOverview button #1181

Merged
merged 1 commit into from
May 11, 2023

Conversation

aindriu-aiven
Copy link
Contributor

Change in API requires finding the environments a topic is provisioned on by a different look up.

About this change - What it does
This change makes a list of the Kafka environments that the topic is provisioned on using existing information instead of information passed in through the API.
Resolves: #xxxxx
Why this way
This means we do not rely on the api to pass the information but it allows us to do a look up using information we already have from a verified source, straight from the db.

…d on by a different look up.

Signed-off-by: Aindriu Lavelle <aindriu.lavelle@aiven.io>
@aindriu-aiven aindriu-aiven requested a review from a team as a code owner May 11, 2023 14:02
Copy link
Contributor

@muralibasani muralibasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. thanks.

@aindriu-aiven aindriu-aiven merged commit ceb82b0 into main May 11, 2023
@aindriu-aiven aindriu-aiven deleted the issue-schema-promo-button-missing branch May 11, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants