-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cluster Api security #125
Merged
Merged
Cluster Api security #125
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 23 additions & 2 deletions
25
src/test/java/io/aiven/klaw/service/ServerConfigServiceTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,35 +1,56 @@ | ||
| package io.aiven.klaw.service; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
| import static org.mockito.ArgumentMatchers.any; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| import io.aiven.klaw.model.ServerConfigProperties; | ||
| import java.util.List; | ||
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.junit.jupiter.api.extension.ExtendWith; | ||
| import org.mockito.Mock; | ||
| import org.mockito.Mockito; | ||
| import org.springframework.context.annotation.AnnotationConfigApplicationContext; | ||
| import org.springframework.core.env.Environment; | ||
| import org.springframework.security.core.Authentication; | ||
| import org.springframework.security.core.context.SecurityContext; | ||
| import org.springframework.security.core.context.SecurityContextHolder; | ||
| import org.springframework.security.core.userdetails.UserDetails; | ||
| import org.springframework.test.context.junit.jupiter.SpringExtension; | ||
|
|
||
| @ExtendWith(SpringExtension.class) | ||
| public class ServerConfigServiceTest { | ||
|
|
||
| @Mock private CommonUtilsService commonUtilsService; | ||
| ServerConfigService serverConfigService; | ||
|
|
||
| @Mock private UserDetails userDetails; | ||
|
|
||
| private Environment env; | ||
|
|
||
| @BeforeEach | ||
| public void setUp() { | ||
| AnnotationConfigApplicationContext context = new AnnotationConfigApplicationContext(); | ||
| this.env = context.getEnvironment(); | ||
| loginMock(); | ||
|
|
||
| serverConfigService = new ServerConfigService(env); | ||
| serverConfigService = new ServerConfigService(env, commonUtilsService); | ||
| } | ||
|
|
||
| @Test | ||
| public void getAllProps() { | ||
| when(commonUtilsService.isNotAuthorizedUser(any(), any())).thenReturn(false); | ||
| serverConfigService.getAllProperties(); | ||
| List<ServerConfigProperties> list = serverConfigService.getAllProps(); | ||
| assertThat(list).isNotEmpty(); | ||
| assertThat(list).isEmpty(); // filtering for spring. and klaw. | ||
| } | ||
|
|
||
| private void loginMock() { | ||
| Authentication authentication = Mockito.mock(Authentication.class); | ||
| SecurityContext securityContext = Mockito.mock(SecurityContext.class); | ||
| when(securityContext.getAuthentication()).thenReturn(authentication); | ||
| when(authentication.getPrincipal()).thenReturn(userDetails); | ||
| SecurityContextHolder.setContext(securityContext); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm not mistaken String.contains is case sensitive. Depending on what is returned for "key", should that be considered here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reethi-kotti-aiven Yes, but it may not be considered here. All the keys are already lower case now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, thank you for the review.