Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: put persist-credentials flag properly #140

Merged
merged 1 commit into from
Oct 24, 2022
Merged

fix: put persist-credentials flag properly #140

merged 1 commit into from
Oct 24, 2022

Conversation

jlprat
Copy link
Contributor

@jlprat jlprat commented Oct 24, 2022

Signed-off-by: Josep Prat josep.prat@klaw-project.io

@jlprat jlprat requested a review from a team as a code owner October 24, 2022 16:38
@jlprat jlprat force-pushed the right-persist-credentials-flag branch from a4af3d2 to c70a6f8 Compare October 24, 2022 16:42
snuyanzin
snuyanzin approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@snuyanzin snuyanzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

MINOR: this thing looks a bit suspicious especially in case of security fix =)
image

@jlprat
fix: put persist-credentials flag properly
c3cb342 
Signed-off-by: Josep Prat <josep.prat@klaw-project.io>
@jlprat jlprat force-pushed the right-persist-credentials-flag branch from c70a6f8 to c3cb342 Compare October 24, 2022 16:47
@jlprat
Copy link
Contributor Author

jlprat commented Oct 24, 2022

I think my changes show as unverified because I used the klaw-project.io email. I'll check later why is that

@st3fan st3fan merged commit 278227b into main Oct 24, 2022
@st3fan st3fan deleted the right-persist-credentials-flag branch October 24, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snuyanzin snuyanzin snuyanzin approved these changes

@st3fan st3fan st3fan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlprat @st3fan @snuyanzin