Enable windows coral build #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ygwin on windows. Signed-off-by: Aindriu Lavelle <aindriu.lavelle@aiven.io>
Signed-off-by: Aindriu Lavelle <aindriu.lavelle@aiven.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable windows coral build and also continue support for tools like cygwin on windows.
What kind of change does this PR introduce?
What is the current behavior?
Currently the make file in core builds coral, however it uses unix commands to do so which do not translate to windows machines preventing windws build users from being able to avail f the coral UI.
What is the new behavior?
Now the make file detects if it is a windows OS and if it is , it does a further check to see if it is a unix like shell if not it executes specific dos and powershell compatible command.
In all other cases it will run the existing UNIX commands.
Other information
N/A
Requirements (all must be checked before review)
mainbranch have been pulledpnpm linthas been run successfully