Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use KafkaClustersType as enum rather than as String #87

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Use KafkaClustersType as enum rather than as String #87

merged 1 commit into from
Oct 17, 2022

Conversation

snuyanzin
Copy link
Contributor

The PR makes use KafkaClustersType rather than String

muralibasani
muralibasani approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@muralibasani muralibasani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snuyanzin Nice change. Looks good to me.

@snuyanzin snuyanzin merged commit 24344d6 into main Oct 17, 2022
@snuyanzin snuyanzin deleted the enum branch October 17, 2022 16:40
@muralibasani muralibasani mentioned this pull request Oct 20, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muralibasani muralibasani muralibasani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snuyanzin @muralibasani